Set a default ClickHouse password required by newest ClickHouse images (#17)

ClickHouse now requires a password to be set for the default user. Also address issues with golangci-lint configuration.

Author: andreev-io

.golangci.yaml

@@ -11,35 +11,37 @@ run:
   # Include test files or not.
   # Default: true
   tests: false
-  issues:
-    # Which files to skip: they will be analyzed, but issues from them won't be reported.
-    # Default value is empty list,
-    # but there is no need to include all autogenerated files,
-    # we confidently recognize autogenerated files.
-    # If it's not please let us know.
-    # "/" will be replaced by current OS file path separator to properly work on Windows.
-    exclude-files:
-      - ".*\\.my\\.go$"
-      - lib/bad.go
-    # Which dirs to skip: issues from them won't be reported.
-    # Can use regexp here: `generated.*`, regexp is applied on full path,
-    # including the path prefix if one is set.
-    # Default value is empty list,
-    # but default dirs are skipped independently of this option's value (see skip-dirs-use-default).
-    # "/" will be replaced by current OS file path separator to properly work on Windows.
-    exclude-dirs:
-      - src/external_libs
-      - autogenerated_by_my_lib
-      - deploy
-      - helpers
-    # Enables skipping of directories:
-    # - vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-    # Default: true
-    exclude-dirs-use-default: true
   # Allow multiple parallel golangci-lint instances running.
   # If false (default) - golangci-lint acquires file lock on start.
-  allow-parallel-runners: false
+  allow-parallel-runners: true
   # Define the Go version limit.
   # Mainly related to generics support since go1.18.
   # Default: use Go version from the go.mod file, fallback on the env var `GOVERSION`, fallback on 1.23
   go: '1.23'
+
+# Move issues section to root level
+issues:
+  # Which files to skip: they will be analyzed, but issues from them won't be reported.
+  # Default value is empty list,
+  # but there is no need to include all autogenerated files,
+  # we confidently recognize autogenerated files.
+  # If it's not please let us know.
+  # "/" will be replaced by current OS file path separator to properly work on Windows.
+  exclude-files:
+    - ".*\\.my\\.go$"
+    - lib/bad.go
+  # Which dirs to skip: issues from them won't be reported.
+  # Can use regexp here: `generated.*`, regexp is applied on full path,
+  # including the path prefix if one is set.
+  # Default value is empty list,
+  # but default dirs are skipped independently of this option's value (see skip-dirs-use-default).
+  # "/" will be replaced by current OS file path separator to properly work on Windows.
+  exclude-dirs:
+    - src/external_libs
+    - autogenerated_by_my_lib
+    - deploy
+    - helpers
+  # Enables skipping of directories:
+  # - vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
+  # Default: true
+  exclude-dirs-use-default: true

deploy/helm/kubenetmon-server/values.yaml

@@ -57,7 +57,7 @@ inserter:
   database: "default"
   endpoint: "clickhouse.default.svc.cluster.local:9000"
   username: "default"
-  password: ""
+  password: "clickhouse"
   dialTimeout: 30s
   maxIdleConnections: 50
   batchSize: 15000

integration/e2e_test.go

@@ -13,7 +13,7 @@ import (
 
 // Run this using Makefile & test/test-kind.sh so that necessary dependencies are spun up.
 func TestEndToEnd(t *testing.T) {
-	conn, err := sql.Open("clickhouse", "tcp://127.0.0.1:9000?username=default")
+	conn, err := sql.Open("clickhouse", "tcp://127.0.0.1:9000?username=default&password=clickhouse")
 	if err != nil {
 		t.Fatalf("Failed to connect to ClickHouse: %v", err)
 	}

test/clickhouse-deployment.yaml

@@ -18,6 +18,11 @@ spec:
       containers:
       - name: clickhouse
         image: clickhouse/clickhouse-server:latest
+        env:
+        - name: CLICKHOUSE_USER
+          value: "default"
+        - name: CLICKHOUSE_PASSWORD
+          value: "clickhouse"
         ports:
         - containerPort: 8123
         - containerPort: 9000