Merge pull request #9 from ClickHouse/ClickHouse/fix-msan-p12_decr

thevar1able · web-flow · commit d5a835834449 · 2026-01-19T15:51:36.000+01:00
Zero out memory after allocation to avoid usage of uninitialized memory
diff --git a/crypto/pkcs12/p12_decr.c b/crypto/pkcs12/p12_decr.c
@@ -75,7 +75,7 @@ unsigned char *PKCS12_pbe_crypt_ex(const X509_ALGOR *algor,
         }
     }
 
-    if ((out = OPENSSL_malloc(max_out_len)) == NULL)
+    if ((out = OPENSSL_zalloc(max_out_len)) == NULL)
         goto err;
 
     if (!EVP_CipherUpdate(ctx, out, &i, in, inlen)) {

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ unsigned char PKCS12_pbe_crypt_ex(const X509_ALGOR algor,`
`75`	`75`	`}`
`76`	`76`	`}`
`77`	`77`
`78`		`- if ((out = OPENSSL_malloc(max_out_len)) == NULL)`
	`78`	`+ if ((out = OPENSSL_zalloc(max_out_len)) == NULL)`
`79`	`79`	`goto err;`
`80`	`80`
`81`	`81`	`if (!EVP_CipherUpdate(ctx, out, &i, in, inlen)) {`