Skip to content

Commit e3e73e2

Browse files
committed
Refactor logger setup
1 parent 56e7125 commit e3e73e2

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

microSALT/__init__.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import logging
2-
import os
32

43
__version__ = "4.3.0"
54

@@ -14,7 +13,7 @@
1413
}
1514

1615

17-
def setup_logger(logging_level: str, log_file: str) -> None:
16+
def setup_logger(logging_level: str) -> None:
1817
global logger
1918
if logging_level not in logging_levels:
2019
raise ValueError(
@@ -28,7 +27,4 @@ def setup_logger(logging_level: str, log_file: str) -> None:
2827
"%(asctime)s - %(name)s - %(levelname)s - %(message)s", "%Y-%m-%d %H:%M:%S"
2928
)
3029
ch.setFormatter(formatter)
31-
fh = logging.FileHandler(os.path.expanduser(log_file))
32-
fh.setFormatter(formatter)
33-
logger.addHandler(fh)
3430
logger.addHandler(ch)

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def config(tmp_path_factory: pytest.TempPathFactory) -> MicroSALTConfig:
8383
)
8484
cfg.config_path = str(base / "config.json")
8585

86-
setup_logger(logging_level="INFO", log_file=cfg.folders.log_file)
86+
setup_logger(logging_level="INFO")
8787
initialize_database(cfg.database.SQLALCHEMY_DATABASE_URI)
8888
return cfg
8989

0 commit comments

Comments
 (0)