Skip to content

Commit 282a2c4

Browse files
feat: update GitHub templates (#24)
### Changed - PR template - PR checklist message body - Feature request template to include the relevant sections of a User Story - Bug report template - Added the follwoing files to list of files to ignore in linting config: - `.github/ISSUE_TEMPLATE/feature_request.yml` - `.github/PULL_REQUEST_TEMPLATE` - `.github/ISSUE_TEMPLATE/config.yml` - `.github/ISSUE_TEMPLATE/bug_report.yml` - Updated issue template chooser `.github/ISSUE_TEMPLATE/config.yml` to include blank issues and remove nf-core contact links
1 parent bc6c26b commit 282a2c4

File tree

7 files changed

+78
-56
lines changed

7 files changed

+78
-56
lines changed
Lines changed: 20 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,38 @@
11
name: Bug report
2-
description: Report something that is broken or incorrect
3-
labels: bug
2+
labels: ["Bug"]
3+
projects: ["Clinical-Genomics/108"]
44
body:
5-
- type: markdown
6-
attributes:
7-
value: |
8-
Before you post this issue, please check the documentation:
9-
10-
- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
11-
- [nf-core/oncorefiner pipeline documentation](https://nf-co.re/oncorefiner/usage)
125
- type: textarea
13-
id: description
146
attributes:
15-
label: Description of the bug
7+
label: Description
168
description: A clear and concise description of what the bug is.
179
validations:
1810
required: true
1911

2012
- type: textarea
21-
id: command_used
2213
attributes:
23-
label: Command used and terminal output
24-
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
25-
render: console
26-
placeholder: |
27-
$ nextflow run ...
14+
label: How to reproduce
15+
description: Steps to reproduce the behaviour. If relevant, please paste the command you used to launch the pipeline and the output from your terminal.
16+
validations:
17+
required: true
2818

29-
Some output where something broke
19+
- type: textarea
20+
attributes:
21+
label: Expected behaviour
22+
description: A clear and concise description of what you expected to happen.
23+
validations:
24+
required: false
3025

3126
- type: textarea
32-
id: files
3327
attributes:
34-
label: Relevant files
28+
label: Anything else?
3529
description: |
30+
Links? Screenshots? Anything that will give us more context about the issue you are encountering!
31+
3632
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
3733
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.
34+
validations:
35+
required: false
3836

3937
- type: textarea
4038
id: system
@@ -46,4 +44,5 @@ body:
4644
* Executor _(eg. slurm, local, awsbatch)_
4745
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
4846
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
49-
* Version of nf-core/oncorefiner _(eg. 1.1, 1.5, 1.8.2)_
47+
* Version of oncorefiner _(eg. 1.1, 1.5, 1.8.2)_
48+
* Version of nf-core/oncoanalyser _(eg. 1.1, 1.5, 1.8.2)_

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1 @@
1-
contact_links:
2-
- name: Join nf-core
3-
url: https://nf-co.re/join
4-
about: Please join the nf-core community here
5-
- name: "Slack #oncorefiner channel"
6-
url: https://nfcore.slack.com/channels/oncorefiner
7-
about: Discussion about the nf-core/oncorefiner pipeline
1+
blank_issues_enabled: true
Lines changed: 40 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,46 @@
11
name: Feature request
2-
description: Suggest an idea for the nf-core/oncorefiner pipeline
3-
labels: enhancement
2+
description: User story
3+
labels: ["User-Story"]
4+
projects: ["Clinical-Genomics/108"]
45
body:
56
- type: textarea
6-
id: description
77
attributes:
8-
label: Description of feature
9-
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
8+
label: Need
9+
description: Describe the need from the perspective of the user.
10+
value: |
11+
As a <role>,
12+
I want <functionality>
13+
because of <reason>.
1014
validations:
1115
required: true
16+
- type: textarea
17+
attributes:
18+
label: Acceptance criteria
19+
description: |
20+
List the requirements needed for this feature to be implemented.
21+
If you are unsure, apply label the "Needs Refinement" to the issue.
22+
value: |
23+
- [ ] <acceptance criterion>
24+
- [ ] <acceptance criterion>
25+
validations:
26+
required: true
27+
28+
- type: textarea
29+
attributes:
30+
label: Additional information
31+
description: |
32+
Please provide any information that can give us more context about this issue.
33+
value: |
34+
- Suggested approach
35+
<!-- Any ideas on how this should be implemented? -->
36+
37+
- Considered alternatives
38+
<!-- Were there alternative approaches which have been rejected? -->
39+
40+
- Blockers
41+
<!-- Anything preventing this from happening?
42+
43+
- Other notes
44+
<!-- Links? References? -->
45+
validations:
46+
required: false

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,15 @@
1-
<!--
2-
# nf-core/oncorefiner pull request
1+
### Added
32

4-
Many thanks for contributing to nf-core/oncorefiner!
3+
-
54

6-
Please fill in the appropriate checklist below (delete whatever is not relevant).
7-
These are the most common things requested on pull requests (PRs).
5+
### Changed
86

9-
Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.
7+
-
108

11-
Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/oncorefiner/tree/master/.github/CONTRIBUTING.md)
12-
-->
9+
### Fixed
1310

14-
## PR checklist
11+
-
1512

16-
- [ ] This comment contains a description of changes (with reason).
17-
- [ ] If you've fixed a bug or added code that should be tested, add tests!
18-
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/oncorefiner/tree/master/.github/CONTRIBUTING.md)
19-
- [ ] If necessary, also make a PR on the nf-core/oncorefiner _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
20-
- [ ] Make sure your code lints (`nf-core pipelines lint`).
21-
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
22-
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
23-
- [ ] Usage Documentation in `docs/usage.md` is updated.
24-
- [ ] Output Documentation in `docs/output.md` is updated.
25-
- [ ] `CHANGELOG.md` is updated.
26-
- [ ] `README.md` is updated (including new tool citations and authors/contributors).
13+
### Removed
14+
15+
-

.github/pr_checklist_comment_body.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
- [ ] Fill in description of the PR and link to any relevant issues.
44
- [ ] If you've fixed a bug or added code that should be tested, add tests!
55
- [ ] If you've added a new tool, follow the pipeline conventions in the [contribution docs](https://github.com/nf-core/oncorefiner/tree/master/.github/CONTRIBUTING.md).
6-
- [ ] Make sure your code lints (`nf-core pipelines lint`).
7-
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
8-
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
96
- [ ] Usage Documentation in `docs/usage.md` is updated.
107
- [ ] Output Documentation in `docs/output.md` is updated.
118
- [ ] `README.md` is updated (including new tool citations and authors/contributors).

.nf-core.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ lint:
99
- assets/nf-core-oncorefiner_logo_light.png
1010
- docs/images/nf-core-oncorefiner_logo_light.png
1111
- docs/images/nf-core-oncorefiner_logo_dark.png
12+
- .github/ISSUE_TEMPLATE/config.yml
13+
- .github/ISSUE_TEMPLATE/bug_report.yml
14+
- .github/ISSUE_TEMPLATE/feature_request.yml
15+
- .github/PULL_REQUEST_TEMPLATE.md
1216
nf_core_version: 3.5.2
1317
repository_type: pipeline
1418
template:

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ Initial release of nf-core/oncorefiner, created with the [nf-core](https://nf-co
1717
- Added small test profile. The related test dataset have been added as a branch called oncorefiner under [Clinical-Genomics/test-datasets](https://github.com/Clinical-Genomics/test-datasets/tree/oncorefiner) [#8](https://github.com/Clinical-Genomics/oncorefiner/pull/8)
1818
- Added CI checks for `Conventional PR title`, `Updated changelog` and `Add PR checklist comment` [#18](https://github.com/Clinical-Genomics/oncorefiner/pull/18)
1919

20+
### Changed
21+
22+
- Updated PR template, PR checklist, feature request template, bug report template and issue template chooser [#24](https://github.com/Clinical-Genomics/oncorefiner/pull/24)
23+
2024
### `Fixed`
2125

2226
- Removed snv_vcf_tbi and sv_vcf_tbi parameter. VCF indexes are now automatically detected [#9](https://github.com/Clinical-Genomics/oncorefiner/pull/9)

0 commit comments

Comments
 (0)