Skip to content

Commit 70ff348

Browse files
fix: Add species parameter (#49)
### Fixed - Added `species` parameter to provide information for annotation which was previously hardcoded. - Added `species` parameter to `nextflow.config` with default value `homo_sapiens`. - Updated nextflow schema. Set parameter to enum with `homo_sapiens` as the only option. - Updated parameters documentation with pre-commit hook.
1 parent 71d30ef commit 70ff348

File tree

5 files changed

+24
-8
lines changed

5 files changed

+24
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ Initial release of Clinical-Genomics/oncorefiner, created with the [nf-core](htt
4444
- Added necessary GITHUB_TOKEN permissions for action add_pr_checklist_comment [#42](https://github.com/Clinical-Genomics/oncorefiner/pull/42)
4545
- Updated all modules and removed deprecated `ch_versions` to implement latest nf-core changes that use the `versions` topic channel to collect software versions [#34](https://github.com/Clinical-Genomics/oncorefiner/pull/34)
4646
- Fixed settings for `add_pr_checklist_comment` to allow action to run on a PR originated from a fork [#45](https://github.com/Clinical-Genomics/oncorefiner/pull/45)
47+
- Added `species` parameter to provide information for annotation which was previously hardcoded [#49](https://github.com/Clinical-Genomics/oncorefiner/pull/49)
4748

4849
### `Dependencies`
4950

docs/parameters.md

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# nf-core/oncorefiner pipeline parameters
1+
# Clinical-Genomics/oncorefiner pipeline parameters
22

33
Customizable post-processing and extension layer built on top of Oncoanalyser that adapts its outputs to clinical and operational needs, adds missing analyses, and ensures flexibility for evolving standards while retaining Oncoanalyser robust core
44

@@ -8,7 +8,7 @@ Define where the pipeline should find input data and save output data.
88

99
| Parameter | Description | Type | Default | Required | Hidden |
1010
|-----------|-----------|-----------|-----------|-----------|-----------|
11-
| `input` | Path to comma-separated file containing information about the samples in the experiment. <details><summary>Help</summary><small>You will need to create a design file with information about the samples in your experiment before running the pipeline. Use this parameter to specify its location. It has to be a comma-separated file with 3 columns, and a header row. See [usage docs](https://nf-co.re/oncorefiner/usage#samplesheet-input).</small></details>| `string` | | True | |
11+
| `input` | Path to comma-separated file containing information about the samples in the experiment. <details><summary>Help</summary><small>You will need to create a design file with information about the samples in your experiment before running the pipeline. Use this parameter to specify its location. It has to be a comma-separated file with 3 columns, and a header row.</small></details>| `string` | | True | |
1212
| `outdir` | The output directory where the results will be saved. You have to use absolute paths to storage on Cloud infrastructure. | `string` | | True | |
1313
| `email` | Email address for completion summary. <details><summary>Help</summary><small>Set this parameter to your e-mail address to get a summary e-mail with details of the run sent to you when the workflow exits. If set in your user config file (`~/.nextflow/config`) then you don't need to specify this on the command line for every run.</small></details>| `string` | | | |
1414
| `multiqc_title` | MultiQC report title. Printed as page header, used for filename if not otherwise specified. | `string` | | | |
@@ -19,11 +19,10 @@ Reference genome related files and options required for the workflow.
1919

2020
| Parameter | Description | Type | Default | Required | Hidden |
2121
|-----------|-----------|-----------|-----------|-----------|-----------|
22-
| `genome` | Name of iGenomes reference. <details><summary>Help</summary><small>If using a reference genome configured in the pipeline using iGenomes, use this parameter to give the ID for the reference. This is then used to build the full paths for all required reference genome files e.g. `--genome GRCh38`. <br><br>See the [nf-core website docs](https://nf-co.re/usage/reference_genomes) for more details.</small></details>| `string` | | | |
23-
| `fasta` | Path to FASTA genome file. <details><summary>Help</summary><small>This parameter is *mandatory* if `--genome` is not specified. If you don't have a BWA index available this will be generated for you automatically. Combine with `--save_reference` to save BWA index for future runs.</small></details>| `string` | | | |
22+
| `fasta` | Path to FASTA genome file. <details><summary>Help</summary><small>If you don't have a BWA index available this will be generated for you automatically. Combine with `--save_reference` to save BWA index for future runs.</small></details>| `string` | | | |
2423
| `fai` | Path to FASTA genome index file. <details><summary>Help</summary><small>If none provided, will be generated automatically from the FASTA reference</small></details>| `string` | | | |
25-
| `igenomes_ignore` | Do not load the iGenomes reference config. <details><summary>Help</summary><small>Do not load `igenomes.config` when running the pipeline. You may choose this option if you observe clashes between custom parameters and those supplied in `igenomes.config`.</small></details>| `boolean` | | | True |
26-
| `igenomes_base` | The base path to the igenomes reference files | `string` | s3://ngi-igenomes/igenomes/ | | True |
24+
| `genome` | Name of the genome reference. (accepted: `GRCh38`\|`GRCh37`) <details><summary>Help</summary><small>Use this parameter to specify the ID for the reference genome used. This is then used to annotate the SV and SNV files e.g. `--genome GRCh38`.</small></details>| `string` | GRCh38 | | |
25+
| `species` | Species of the reference genome. E.g. `--species homo_sapiens`. (accepted: `homo_sapiens`) | `string` | homo_sapiens | | |
2726

2827
## Annotation options
2928

@@ -75,3 +74,11 @@ Less common options for the pipeline, typically set in a config file.
7574
| `help` | Display the help message. | `['boolean', 'string']` | | | |
7675
| `help_full` | Display the full detailed help message. | `boolean` | | | |
7776
| `show_hidden` | Display hidden parameters in the help message (only works when --help or --help_full are provided). | `boolean` | | | |
77+
78+
## Other parameters
79+
80+
| Parameter | Description | Type | Default | Required | Hidden |
81+
|-----------|-----------|-----------|-----------|-----------|-----------|
82+
| `snv_vcf` | | `string` | | | |
83+
| `sv_vcf` | | `string` | | | |
84+
| `custom_extra_files` | | `string` | | | |

nextflow.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ params {
3737
fasta = null
3838
fai = null
3939
genome = 'GRCh38'
40+
species = 'homo_sapiens'
4041

4142
// MultiQC options
4243
multiqc_config = null

nextflow_schema.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,13 @@
7575
"description": "Path to FASTA genome index file.",
7676
"pattern": "^\\S+\\.fn?a(sta)?\\.fai$",
7777
"fa_icon": "fas fa-file"
78+
},
79+
"species": {
80+
"type": "string",
81+
"default": "homo_sapiens",
82+
"enum": ["homo_sapiens"],
83+
"description": "Species of the reference genome. E.g. `--species homo_sapiens`.",
84+
"help_text": ""
7885
}
7986
}
8087
},

workflows/oncorefiner.nf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ workflow ONCOREFINER {
146146
ENSEMBLVEP_SNV (
147147
ch_vep_snv,
148148
params.genome,
149-
"homo_sapiens",
149+
params.species,
150150
params.vep_cache_version,
151151
ch_vep_cache,
152152
ch_genome_fasta,
@@ -210,7 +210,7 @@ workflow ONCOREFINER {
210210
ENSEMBLVEP_SV(
211211
ch_vep_sv,
212212
params.genome,
213-
"homo_sapiens",
213+
params.species,
214214
params.vep_cache_version,
215215
ch_vep_cache,
216216
ch_genome_fasta,

0 commit comments

Comments
 (0)