Skip to content

feat: Strict syntax compatibility to enable better error reporting#30

Merged
fellen31 merged 8 commits intoClinical-Genomics:devfrom
fellen31:29-strict-syntax-compatability
Mar 5, 2026
Merged

feat: Strict syntax compatibility to enable better error reporting#30
fellen31 merged 8 commits intoClinical-Genomics:devfrom
fellen31:29-strict-syntax-compatability

Conversation

@fellen31
Copy link
Contributor

@fellen31 fellen31 commented Mar 4, 2026

Closes #29, by providing the minimum requirements for enabling strict syntax when developing locally.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/oncorefiner branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@fellen31 fellen31 force-pushed the 29-strict-syntax-compatability branch from b6537bc to 81c1971 Compare March 4, 2026 14:59
@fellen31 fellen31 marked this pull request as ready for review March 4, 2026 15:53
@fellen31 fellen31 requested a review from a team as a code owner March 4, 2026 15:53
Copy link
Collaborator

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks a lot! Is this also fixing the last requirement on the linked issue ’Fix strict syntax errors identified by the Nextflow language server’ ? I don't think I understand what the Nextflow language server is

@fellen31
Copy link
Contributor Author

fellen31 commented Mar 5, 2026

Awesome thanks a lot! Is this also fixing the last requirement on the linked issue ’Fix strict syntax errors identified by the Nextflow language server’ ? I don't think I understand what the Nextflow language server is

Yes, there seems to be no incompatibilities with strict syntax for oncorefiner, i.e. the pipeline runs fine with strict syntax enabled. You can use the Nextflow language server in for example VS code for syntax highlighting, diagnostics, hover hints etc.

You do have some things that could be fixed, but they are not major issues so Nextflow will still run with these problems in strict mode:
Screenshot 2026-03-05 at 13 37 57

@fellen31 fellen31 requested a review from fevac March 5, 2026 12:44
@fellen31
Copy link
Contributor Author

fellen31 commented Mar 5, 2026

Updated the changelog, I'll let you just take one more look before I merge to make sure it looks ok to you!

Copy link
Contributor

@kristinebilgrav kristinebilgrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks! 🌟

Copy link
Collaborator

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fellen31 fellen31 merged commit 43626fe into Clinical-Genomics:dev Mar 5, 2026
6 checks passed
@fellen31 fellen31 deleted the 29-strict-syntax-compatability branch March 5, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strict syntax compatibility

4 participants