You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added new include_process parameter allowing users to selectively enable or disable specific processing steps.
Changed
Refactored workflow to use a ch_current_*_vcf pattern, allowing sequential conditional execution of processing steps.
local annotation, filtering, VEP annotation, and clinical filtering for both SNV and SVs are now conditionally executed based on the include_process configuration.
Avoid overriding and reusing the same input variable for all steps (This is a programming bad practice. For example, if a bug is introduced that makes a mandatory step not run, the pipeline will run anyway, but incorrectly, because the input variable already exists. It also makes it hard to trace back where the contents of the chanel are coming from.)
Consider changing the logic to focus on skip instead of include:
There can be a skip_subworkflow for several connected steps and a skip_tools for specific tools instead.
Consider creating 4 general subworkflows that can be skipped:
Local/Ensembl_vep annotation
Clinical/Research filtering
The benefit of subworkflows is that you already have a standardized output by default. No matter what tools are skipped/included in the workflow, the output is always the same subworkflow.out.
More general suggestion: Separate SV and SNV processing into 2 subworkflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Clinical-Genomics/CancerBioInfo/issues/97
Added
Changed