Skip to content

Ensure block and transaction size and weight values match old codebase #33

@r3rcloak

Description

@r3rcloak

Cloak and BTC have different consensus values blocks and transactions. Cloak also have a specific MAX_BLOCK_SIZE_GEN value for PoS generated blocks. This should be followed and updated in the new codebase.

MAX_BLOCK_SIZE and MAX_BLOCK_SIZE_GEN [PoS blocks] (in old codebase)
MAX_BLOCK_SERIALIZED_SIZE and MAX_BLOCK_WEIGHT (in new codebase).

It is also critical to ensure consensus rules match when validating transactions and blocks (see CheckTransaction in tx_verify.cpp and CheckBlock in validation.cpp). Any failure here could result in a fork due to transactions or blocks being accepted by a subset of nodes due to differing block/tx consensus rules.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Sync/ConsensusIssues related to block syncing / network consensus rulesTaskA development taskquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions