Inventory api overhaul and more server auth impl

Author: Kazzuk

api/src/main/java/module-info.java

@@ -1,18 +1,18 @@
 open module org.cloudburstmc.api {
+    requires static lombok;
     requires static org.checkerframework.checker.qual;
-    requires tools.jackson.core;
-    requires tools.jackson.databind;
     requires com.fasterxml.jackson.annotation;
-    requires tools.jackson.dataformat.properties;
-    requires tools.jackson.dataformat.yaml;
     requires com.google.common;
     requires com.google.guice;
     requires jakarta.inject;
     requires java.desktop;
-    requires static lombok;
+    requires java.sql;
     requires org.cloudburstmc.math.immutable;
     requires org.slf4j;
-    requires java.sql;
+    requires tools.jackson.core;
+    requires tools.jackson.databind;
+    requires tools.jackson.dataformat.properties;
+    requires tools.jackson.dataformat.yaml;
 
     exports org.cloudburstmc.api;
     exports org.cloudburstmc.api.block;
@@ -41,7 +41,8 @@
     exports org.cloudburstmc.api.event.redstone;
     exports org.cloudburstmc.api.event.server;
     exports org.cloudburstmc.api.event.vehicle;
-    exports org.cloudburstmc.api.container;
+    exports org.cloudburstmc.api.inventory;
+    exports org.cloudburstmc.api.inventory.view;
     exports org.cloudburstmc.api.item;
     exports org.cloudburstmc.api.item.behavior;
     exports org.cloudburstmc.api.item.data;
@@ -61,6 +62,4 @@
     exports org.cloudburstmc.api.util;
     exports org.cloudburstmc.api.util.behavior;
     exports org.cloudburstmc.api.util.data;
-    exports org.cloudburstmc.api.container.screen;
-    exports org.cloudburstmc.api.container.view;
 }

api/src/main/java/org/cloudburstmc/api/blockentity/Barrel.java

@@ -1,7 +1,9 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
-
-public interface Barrel extends BlockEntity, BlockContainerView {
+import org.cloudburstmc.api.inventory.view.BlockStorageView;
 
+/**
+ * A barrel block entity with 27 storage slots.
+ */
+public interface Barrel extends BlockEntity, BlockStorageView {
 }

api/src/main/java/org/cloudburstmc/api/blockentity/BlockEntityTypes.java

@@ -2,10 +2,12 @@
 
 import lombok.experimental.UtilityClass;
 
+/**
+ * Registry of {@link BlockEntityType} constants for all built-in block entity types.
+ */
 @SuppressWarnings("RedundantModifiersUtilityClassLombok")
 @UtilityClass
 public class BlockEntityTypes {
-
     public static final BlockEntityType<Banner> BANNER = BlockEntityType.from("banner", Banner.class);
     public static final BlockEntityType<Barrel> BARREL = BlockEntityType.from("barrel", Barrel.class);
     public static final BlockEntityType<Beacon> BEACON = BlockEntityType.from("beacon", Beacon.class);
@@ -18,13 +20,14 @@ public class BlockEntityTypes {
     public static final BlockEntityType<Chest> CHEST = BlockEntityType.from("chest", Chest.class);
     public static final BlockEntityType<CommandBlock> COMMAND_BLOCK = BlockEntityType.from("command_block", CommandBlock.class);
     public static final BlockEntityType<Comparator> COMPARATOR = BlockEntityType.from("comparator", Comparator.class);
+    public static final BlockEntityType<Crafter> CRAFTER = BlockEntityType.from("crafter", Crafter.class);
     public static final BlockEntityType<DaylightDetector> DAYLIGHT_DETECTOR = BlockEntityType.from("daylight_detector", DaylightDetector.class);
     public static final BlockEntityType<Dispenser> DISPENSER = BlockEntityType.from("dispenser", Dispenser.class);
     public static final BlockEntityType<Dropper> DROPPER = BlockEntityType.from("dropper", Dropper.class);
     public static final BlockEntityType<EnchantingTable> ENCHANTING_TABLE = BlockEntityType.from("enchanting_table", EnchantingTable.class);
-    public static final BlockEntityType<EnderChest> ENDER_CHEST = BlockEntityType.from("ender_chest", EnderChest.class);
     public static final BlockEntityType<EndGateway> END_GATEWAY = BlockEntityType.from("end_gateway", EndGateway.class);
     public static final BlockEntityType<EndPortal> END_PORTAL = BlockEntityType.from("end_portal", EndPortal.class);
+    public static final BlockEntityType<EnderChest> ENDER_CHEST = BlockEntityType.from("ender_chest", EnderChest.class);
     public static final BlockEntityType<FlowerPot> FLOWER_POT = BlockEntityType.from("flower_pot", FlowerPot.class);
     public static final BlockEntityType<Furnace> FURNACE = BlockEntityType.from("furnace", Furnace.class);
     public static final BlockEntityType<Hopper> HOPPER = BlockEntityType.from("hopper", Hopper.class);
@@ -42,5 +45,4 @@ public class BlockEntityTypes {
     public static final BlockEntityType<Skull> SKULL = BlockEntityType.from("skull", Skull.class);
     public static final BlockEntityType<Smoker> SMOKER = BlockEntityType.from("smoker", Smoker.class);
     public static final BlockEntityType<StructureBlock> STRUCTURE_BLOCK = BlockEntityType.from("structure_block", StructureBlock.class);
-
 }

api/src/main/java/org/cloudburstmc/api/blockentity/BrewingStand.java

@@ -1,23 +1,9 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
-import org.cloudburstmc.api.item.ItemStack;
+import org.cloudburstmc.api.inventory.view.BlockBrewingStandView;
 
-public interface BrewingStand extends BlockEntity, BlockContainerView {
-
-    short getCookTime();
-
-    void setCookTime(int cookTime);
-
-    short getFuelAmount();
-
-    void setFuelAmount(int fuelAmount);
-
-    ItemStack getIngredient();
-
-    void setIngredient(ItemStack ingredient);
-
-    ItemStack getFuel();
-
-    void setFuel(ItemStack fuel);
+/**
+ * A brewing stand block entity that brews potions from an ingredient and up to three bottles.
+ */
+public interface BrewingStand extends BlockEntity, BlockBrewingStandView {
 }

api/src/main/java/org/cloudburstmc/api/blockentity/Chest.java

@@ -1,8 +1,11 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
+import org.cloudburstmc.api.inventory.view.BlockStorageView;
 
-public interface Chest extends BlockEntity, BlockContainerView {
+/**
+ * A chest block entity with 27 storage slots. Two adjacent chests can be paired to form a double chest.
+ */
+public interface Chest extends BlockEntity, BlockStorageView {
 
     boolean isFindable();
 

api/src/main/java/org/cloudburstmc/api/blockentity/Crafter.java

@@ -0,0 +1,9 @@
+package org.cloudburstmc.api.blockentity;
+
+import org.cloudburstmc.api.inventory.view.BlockCrafterView;
+
+/**
+ * A crafter block entity with a 9-slot crafting grid and per-slot disable flags for automated crafting.
+ */
+public interface Crafter extends BlockEntity, BlockCrafterView {
+}

api/src/main/java/org/cloudburstmc/api/blockentity/Dispenser.java

@@ -1,6 +1,9 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
+import org.cloudburstmc.api.inventory.view.BlockDispenserView;
 
-public interface Dispenser extends BlockEntity, BlockContainerView {
+/**
+ * A dispenser block entity with a 9-slot inventory that fires or uses items when powered by redstone.
+ */
+public interface Dispenser extends BlockEntity, BlockDispenserView {
 }

api/src/main/java/org/cloudburstmc/api/blockentity/Dropper.java

@@ -1,6 +1,9 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
+import org.cloudburstmc.api.inventory.view.BlockDropperView;
 
-public interface Dropper extends BlockEntity, BlockContainerView {
+/**
+ * A dropper block entity with a 9-slot inventory that ejects items into the world or an adjacent container when powered by redstone.
+ */
+public interface Dropper extends BlockEntity, BlockDropperView {
 }

api/src/main/java/org/cloudburstmc/api/blockentity/Furnace.java

@@ -1,19 +1,9 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
-import org.cloudburstmc.api.item.ItemStack;
+import org.cloudburstmc.api.inventory.view.BlockFurnaceView;
 
-public interface Furnace extends BlockEntity, BlockContainerView {
-
-    ItemStack getResult();
-
-    void setResult(ItemStack item);
-
-    ItemStack getFuel();
-
-    void setFuel(ItemStack item);
-
-    ItemStack getSmelting();
-
-    void setSmelting(ItemStack item);
+/**
+ * A furnace block entity with ingredient, fuel, and result slots that smelts items over time.
+ */
+public interface Furnace extends BlockEntity, BlockFurnaceView {
 }

api/src/main/java/org/cloudburstmc/api/blockentity/Hopper.java

@@ -1,6 +1,9 @@
 package org.cloudburstmc.api.blockentity;
 
-import org.cloudburstmc.api.container.view.BlockContainerView;
+import org.cloudburstmc.api.inventory.view.BlockHopperView;
 
-public interface Hopper extends BlockEntity, BlockContainerView {
+/**
+ * A hopper block entity with 5 slots that automatically pulls items from containers above and pushes items into containers below.
+ */
+public interface Hopper extends BlockEntity, BlockHopperView {
 }