Always release buffer

rubik-cube-man · SupremeMortal · commit f5e97a18242d · 2025-12-12T15:03:21.000Z
diff --git a/common/src/main/java/org/cloudburstmc/protocol/common/util/Zlib.java b/common/src/main/java/org/cloudburstmc/protocol/common/util/Zlib.java
@@ -66,11 +66,10 @@ public ByteBuf inflate(ByteBuf buffer, int maxSize) throws DataFormatException {
                     throw new DataFormatException("Inflated data exceeds maximum size");
                 }
             }
+            decompressed.retain();
             return decompressed;
-        } catch (DataFormatException e) {
-            decompressed.release();
-            throw e;
         } finally {
+            decompressed.release();
             if (source != null && source != buffer) {
                 source.release();
             }

Original file line number	Diff line number	Diff line change
`@@ -66,11 +66,10 @@ public ByteBuf inflate(ByteBuf buffer, int maxSize) throws DataFormatException {`
`66`	`66`	`throw new DataFormatException("Inflated data exceeds maximum size");`
`67`	`67`	`}`
`68`	`68`	`}`
	`69`	`+ decompressed.retain();`
`69`	`70`	`return decompressed;`
`70`		`- } catch (DataFormatException e) {`
`71`		`- decompressed.release();`
`72`		`- throw e;`
`73`	`71`	`} finally {`
	`72`	`+ decompressed.release();`
`74`	`73`	`if (source != null && source != buffer) {`
`75`	`74`	`source.release();`
`76`	`75`	`}`