Skip to content

Commit 6fb23e1

Browse files
committed
Dev: ui_sbd: Validate purge option first
And give error if the option is not crashdump
1 parent 2a1aca0 commit 6fb23e1

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

crmsh/ui_sbd.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -597,16 +597,25 @@ def do_purge(self, context, *args) -> bool:
597597
if not self._service_is_active(constants.SBD_SERVICE):
598598
return False
599599

600+
purge_crashdump = False
601+
if args:
602+
if args[0] == "crashdump":
603+
if not self._is_crashdump_configured():
604+
logger.error("SBD crashdump is not configured")
605+
return False
606+
purge_crashdump = True
607+
else:
608+
logger.error("Invalid argument: %s", ' '.join(args))
609+
logger.info("Usage: crm sbd purge [crashdump]")
610+
return False
611+
600612
utils.check_all_nodes_reachable("purging SBD")
601613

602614
with utils.leverage_maintenance_mode() as enabled:
603615
if not utils.able_to_restart_cluster(enabled):
604616
return False
605617

606-
if args and args[0] == "crashdump":
607-
if not self._is_crashdump_configured():
608-
logger.error("SBD crashdump is not configured")
609-
return False
618+
if purge_crashdump:
610619
self._set_crashdump_option(delete=True)
611620
update_dict = self._set_crashdump_in_sysconfig(restore=True)
612621
if update_dict:

0 commit comments

Comments
 (0)