Fix: Cooldown Bans Starting Immediately (#463)

* add more logs and update secondsInQueue (#456)

Co-authored-by: Sneer-ra2 <116219243+Sneer-ra2@users.noreply.github.com>

* set AutoSaveInterval to 0

* update secondsInQueue to use updated_at

* fix secondsInQueue bug

* update player name fix

* account-settings updates

* Fix: Cooldown should start on connect (#452) (#461)

* Fix: Cooldown should start on connect (#452)

* Fix: Cooldown should start on connect

* Fix: Cooldown should start on connect

* housekeeping

---------

Co-authored-by: TF338 <211804947+TF338@users.noreply.github.com>

* fix cooldown

---------

Co-authored-by: Sneer-ra2 <116219243+Sneer-ra2@users.noreply.github.com>
Co-authored-by: TF338 <211804947+TF338@users.noreply.github.com>

Author: 3 people

cncnet-api/app/Http/Controllers/AdminController.php

@@ -1312,7 +1312,7 @@ public function editUserBan(Request $request, $ladderId = null, $playerId = null
 
         $user = $player->user;
 
-        $expires = $ban->expires->eq(\App\Models\Ban::unstartedBanTime()) ? null : $ban->expires;
+        $expires = $ban->started() ? $ban->expires : null;
 
         return view(
             "admin.edit-ban",

cncnet-api/app/Models/Ban.php

@@ -116,7 +116,7 @@ public function started()
      */
     public function checkStartBan($startBanStraightAway = false)
     {
-        // Log::debug("checkStartBan: ban_id=" . $this->id . ", startBanStraightAway=" . $startBanStraightAway . ", ban_type=" . $this->ban_type . ", desc=" . Ban::typeToDescription($this->ban_type) . ", expires=" . $this->expires);
+        // Log::debug("checkStartBan: ban_id=" . ($this->id ?? 'NULL') . ", startBanStraightAway=" . ($startBanStraightAway ? 'true' : 'false') . ", ban_type=" . $this->ban_type . ", expires=" . ($this->expires ?? 'NULL') . ", started=" . ($this->started() ? 'true' : 'false'));
 
         $banned = false;
         $cooldown = false;

cncnet-api/database/migrations/2025_12_30_001343_allow_null_expires_in_bans_table.php

@@ -0,0 +1,30 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+
+return new class extends Migration
+{
+    /**
+     * Run the migrations.
+     */
+    public function up(): void
+    {
+        Schema::table('bans', function (Blueprint $table) {
+            // Allow NULL for expires column so cooldown bans can remain unstarted
+            $table->timestamp('expires')->nullable()->default(null)->change();
+        });
+    }
+
+    /**
+     * Reverse the migrations.
+     */
+    public function down(): void
+    {
+        Schema::table('bans', function (Blueprint $table) {
+            // Revert to NOT NULL with default '0000-00-00 00:00:00'
+            $table->timestamp('expires')->nullable(false)->default('0000-00-00 00:00:00')->change();
+        });
+    }
+};

cncnet-api/resources/views/admin/moderate-player.blade.php

@@ -154,7 +154,7 @@
                                             @endif
                                         </td>
 
-                                        @if ($ban->expires === null || $ban->expires->eq(\App\Models\Ban::unstartedBanTime()))
+                                        @if (!$ban->started())
                                             <td>Not Started</td>
                                             <td>
                                                 <form method="POST"