[SEARCH] update search to match legacy return format

Author: rohsyl

app/Extensions/Services/Maps/MapService.php

@@ -151,9 +151,11 @@ public function search(string $game, string $query, ?int $age): array {
                     continue;
 
                 $output[] = [
-                    'raw' => $line,
+                    'name' => trim($name),
+                    'game' => $game,
                     'date' => date('Y-m-d H:i', $date),
-                    'sha1' => $sha1,
+                    'hash' => $sha1,
+                    'raw' => $line,
                     'url' => $game . '/' . $sha1 . '.zip'
                 ];
 

app/Http/Controllers/Api/V1/Maps/SearchController.php

@@ -19,8 +19,22 @@ public function __construct(MapService $mapService)
     public function __invoke(SearchMapRequest $request)
     {
         $inputs = $request->validated();
+        $raw = $inputs['raw'] ?? false;
         $result = $this->mapService->search($inputs['game'], $inputs['search'], $inputs['age'] ?? 0);
 
-        return response()->json($result, 200);
+        if($raw) {
+            return join(PHP_EOL, array_map(fn($m) => $m['raw'], $result));
+        }
+        else {
+            $out = 'Use the /map command to select or suggest the map on CnCNet (you must be inside of a game room)<br /><br /><br /><br />';
+
+            foreach ($result as $map) {
+                $out .= $map['date'] . ' &emsp;/map ' . $map['hash'] . '&emsp; <A href="./' . $map['game'] . '/' . $map['hash'] . '.zip' . '">' .
+                    strip_tags($map['name']) .
+                    '</a><br /><br />';
+            }
+            return $out;
+        }
+
     }
 }

app/Http/Requests/Api/V1/Maps/SearchMapRequest.php

@@ -25,6 +25,7 @@ public function rules(): array
             'game' => 'required|string|in:' . join(',', config('cncnet.games')),
             'search' => 'required|string|min:3',
             'age' => 'nullable|integer|min:0',
+            'raw' => 'nullable|boolean',
         ];
     }
 }

tests/Feature/SearchTest.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Tests\Feature;
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Foundation\Testing\WithFaker;
+use Tests\TestCase;
+
+class SearchTest extends TestCase
+{
+    /**
+     * A basic feature test example.
+     */
+    public function test_example(): void
+    {
+        $response = $this->get('/');
+
+        $response->assertStatus(200);
+    }
+}