add map download

Author: rohsyl

app/Http/Controllers/Api/V1/Maps/DownloadController.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace App\Http\Controllers\Api\V1\Maps;
+
+use App\Http\Controllers\Controller;
+use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Storage;
+
+class DownloadController extends Controller
+{
+    public function __invoke(string $game, string $map)
+    {
+        $path = $game . '/' . $map;
+        if(!Storage::exists($path)) {
+            abort(404);
+        }
+        return Storage::download($path);
+    }
+}

app/Http/Controllers/Api/V1/Maps/SearchController.php

@@ -29,7 +29,7 @@ public function __invoke(SearchMapRequest $request)
             $out = 'Use the /map command to select or suggest the map on CnCNet (you must be inside of a game room)<br /><br /><br /><br />';
 
             foreach ($result as $map) {
-                $out .= $map['date'] . ' &emsp;/map ' . $map['hash'] . '&emsp; <A href="./' . $map['game'] . '/' . $map['hash'] . '.zip' . '">' .
+                $out .= $map['date'] . ' &emsp;/map ' . $map['hash'] . '&emsp; <a href="'.url('/').'/' . $map['game'] . '/' . $map['hash'] . '.zip' . '">' .
                     strip_tags($map['name']) .
                     '</a><br /><br />';
             }

routes/api.php

@@ -1,7 +1,9 @@
 <?php
 
+use App\Http\Controllers\Api\V1\Maps\DownloadController;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Route;
 
 Route::post('/upload', \App\Http\Controllers\Api\V1\Maps\UploadController::class);
-Route::get('/search', \App\Http\Controllers\Api\V1\Maps\SearchController::class)->middleware('throttle:map_search');
+Route::get('/search', \App\Http\Controllers\Api\V1\Maps\SearchController::class)->middleware('throttle:map_search');
+Route::get('/{game}/{map}', DownloadController::class);

routes/web.php

@@ -1,5 +1,3 @@
 <?php
 
 use Illuminate\Support\Facades\Route;
-
-Route::post('/upload', \App\Http\Controllers\Api\V1\Maps\UploadController::class);

tests/Feature/DownloadTest.php

@@ -0,0 +1,25 @@
+<?php
+
+namespace Tests\Feature;
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Foundation\Testing\WithFaker;
+use Illuminate\Support\Facades\Storage;
+use Tests\TestCase;
+
+class DownloadTest extends TestCase
+{
+    /**
+     * A basic feature test example.
+     */
+    public function test_map_download(): void
+    {
+        Storage::fake();
+        Storage::put('yr/889ca47cfcbe6005eac846ed1dcd14a1eefe6fa3.zip', Storage::disk('tests')->get('yr/889ca47cfcbe6005eac846ed1dcd14a1eefe6fa3.zip'));
+
+        $response = $this->get('/yr/889ca47cfcbe6005eac846ed1dcd14a1eefe6fa3.zip');
+
+        $response->assertStatus(200);
+        $response->assertHeader('Content-Type', 'application/zip');
+    }
+}