Fix potential UB in GetLatencyMessage using static (#56)

Belonit · web-flow · commit 7df9b757fe3f · 2025-11-17T16:15:10.000+03:00
diff --git a/src/Spawner/ProtocolZero.LatencyLevel.cpp b/src/Spawner/ProtocolZero.LatencyLevel.cpp
@@ -57,7 +57,7 @@ void LatencyLevel::Apply(LatencyLevelEnum newLatencyLevel)
 
 int LatencyLevel::GetMaxAhead(LatencyLevelEnum latencyLevel)
 {
-	const int maxAhead[] =
+	static const int maxAhead[] =
 	{
 		/* 0 */ 1
 
@@ -77,7 +77,7 @@ int LatencyLevel::GetMaxAhead(LatencyLevelEnum latencyLevel)
 
 const wchar_t* LatencyLevel::GetLatencyMessage(LatencyLevelEnum latencyLevel)
 {
-	const wchar_t* message[] =
+	static const wchar_t* message[] =
 	{
 		/* 0 */ L"CnCNet: Latency mode set to: 0 - Initial" // Players should never see this, if it doesn't then it's a bug
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ void LatencyLevel::Apply(LatencyLevelEnum newLatencyLevel)`
`57`	`57`
`58`	`58`	`int LatencyLevel::GetMaxAhead(LatencyLevelEnum latencyLevel)`
`59`	`59`	`{`
`60`		`- const int maxAhead[] =`
	`60`	`+ static const int maxAhead[] =`
`61`	`61`	`{`
`62`	`62`	`/* 0 */ 1`
`63`	`63`
`@@ -77,7 +77,7 @@ int LatencyLevel::GetMaxAhead(LatencyLevelEnum latencyLevel)`
`77`	`77`
`78`	`78`	`const wchar_t* LatencyLevel::GetLatencyMessage(LatencyLevelEnum latencyLevel)`
`79`	`79`	`{`
`80`		`- const wchar_t* message[] =`
	`80`	`+ static const wchar_t* message[] =`
`81`	`81`	`{`
`82`	`82`	`/* 0 */ L"CnCNet: Latency mode set to: 0 - Initial" // Players should never see this, if it doesn't then it's a bug`
`83`	`83`