DisableGameSpeed support (#53)

* Beginning Stages

* rename hook declarations

* Restore observer gamespeed changes for skirmish attempt

* Fix spaces to tab idents

* Testing #3 or w/e

* reverse naming scheme to make it not inversed

* Remove networking patches

Remove networking patches

* Simplifies GameSpeedSlider logic

Removes the redundant `IsDisabled` method and inverts the logic
where it was used. This simplifies the code and makes it easier to
understand the enabled/disabled state of the game speed slider.

* Redo `DisableGameSpeed`, remove redundant code

---------

Co-authored-by: Metadorius <[email protected]>

Author: CnCRAZER

src/Misc/Observers.cpp

@@ -73,12 +73,15 @@ DEFINE_HOOK(0x658473, RadarClass__658330_SetObserverFlag, 0x5)
 
 #pragma endregion HouseClass is Observer
 
-// Allow skirmish observer to control gamespeed
-// TODO: Allow control speed in skirmish if all human players is Observer
 DEFINE_HOOK(0x4E20BA, GameControlsClass__SomeDialog, 0x5)
 {
 	enum { AllowControlSpeed = 0x4E211A, ForbidControlSpeed = 0x4E20C3 };
 
+	if (Spawner::Enabled && Spawner::GetConfig()->DisableGameSpeed)
+		return ForbidControlSpeed;
+
+	// Allow skirmish observer to control gamespeed (vanilla game doesn't allow this)
+	// TODO: Allow control speed in skirmish if all human players is Observer
 	return (SessionClass::IsSkirmish() && Game::ObserverMode)
 		? AllowControlSpeed
 		: 0;

src/Spawner/Spawner.Config.cpp

@@ -108,6 +108,7 @@ void SpawnerConfig::LoadFromINIFile(CCINIClass* pINI)
 	// Extended Options
 	{
 		Ra2Mode                  = pINI->ReadBool(pSettingsSection, "Ra2Mode", Ra2Mode);
+		DisableGameSpeed         = pINI->ReadBool(pSettingsSection, "DisableGameSpeed", DisableGameSpeed);
 		QuickMatch               = pINI->ReadBool(pSettingsSection, "QuickMatch", QuickMatch);
 		SkipScoreScreen          = pINI->ReadBool(pSettingsSection, "SkipScoreScreen", SkipScoreScreen);
 		WriteStatistics          = pINI->ReadBool(pSettingsSection, "WriteStatistics", WriteStatistics);

src/Spawner/Spawner.Config.h

@@ -137,6 +137,7 @@ class SpawnerConfig
 
 	// Extended Options
 	bool Ra2Mode;
+	bool DisableGameSpeed;
 	bool QuickMatch;
 	bool SkipScoreScreen;
 	bool WriteStatistics;
@@ -229,6 +230,7 @@ class SpawnerConfig
 
 		// Extended Options
 		, Ra2Mode { false }
+		, DisableGameSpeed { false }
 		, QuickMatch { false }
 		, SkipScoreScreen { Main::GetConfig()->SkipScoreScreen }
 		, WriteStatistics { false }