Fix no private access CI/CD builds and some more stuff (#32)

* Fix no private access CI/CD builds

* Missed array brackets

* how can I have an error on a COMMENT line

* Adjust YRpp repo path to point to mainline one in attempt to fix compilation

* Add github.com hostkey to known hosts

* Also create the folder too
github y u do dis

* apparently I lack `touch` experience

* Attempting to salvage the situation by using an unmerged version of checkout action

* Switch to fixed custom checkout action

* Adjust necessary files in artifacts

* fix copy command

* nevermind

Author: Metadorius

.github/actions/build/action.yml

@@ -30,11 +30,12 @@ runs:
       run: msbuild /m /p:Configuration=${{inputs.build-config}} /p:GitCommit=${{github.sha}} /p:GitBranch=${{github.ref}} /v:q ${{inputs.sln-path}}
       shell: cmd
 
-    - name: Upload Artifact
+    - name: Upload artifact
       if: ${{ success() && inputs.artifact-name != '' }}
       uses: actions/upload-artifact@v4
       with:
         name: ${{ inputs.artifact-name }}
         path: |
+          ${{inputs.sln-path}}/LICENSE.md
           ${{inputs.sln-path}}/${{inputs.build-config}}/CnCNet-Spawner.dll
-          ${{inputs.sln-path}}/${{inputs.build-config}}/CnCNet-Spawner.pdb
+          ${{!contains(inputs.build-config, 'Hardened') && format('{0}/{1}/CnCNet-Spawner.pdb', inputs.sln-path, inputs.build-config)}}

.github/workflows/nightly-build.yml

@@ -17,12 +17,21 @@ jobs:
         build-type: [DevBuild]  # [Debug, DevBuild, Release]
         is-cncnet-yr: ['', -CnCNetYR]
         is-hardened: ['', -Hardened]
+        # this dimension is only needed to check whether we're in CnCNet repo
+        # and exclude hardened build because we may have no access to it
+        has-private-access:
+          - ${{ github.repository_owner == 'CnCNet' }}
+        exclude:
+          - is-hardened: -Hardened
+            has-private-access: false
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: Metadorius/checkout@d1a22c1aff33852a0154ff5262e4eab45178154c # fixed SpecificSubmodule branch
         with:
-          submodules: recursive
           ssh-key: ${{ secrets.CNCNET_CI_SSH_PRIVATEKEY }}
+          submodule-directories: |
+            YRpp
+            ${{ matrix.has-private-access && 'Private' }}
 
       - name: Build
         uses: ./.github/actions/build

.github/workflows/release-build.yml

@@ -30,7 +30,11 @@ jobs:
           build-config: ${{ env.BUILD_CONFIG }}
 
       - name: Create an Archive for the Release
-        run: 7z a ${{ env.ARCHIVE_NAME }}.zip ./LICENSE.md ./${{ env.BUILD_CONFIG }}/CnCNet-Spawner.dll ./${{ env.BUILD_CONFIG }}/CnCNet-Spawner.pdb
+        run: >
+          7z a ${{ env.ARCHIVE_NAME }}.zip
+          ./LICENSE.md
+          ./${{ env.BUILD_CONFIG }}/CnCNet-Spawner.dll
+          ${{!contains(env.BUILD_CONFIG, 'Hardened') && format('./{0}/CnCNet-Spawner.pdb', env.BUILD_CONFIG)}}
 
       - name: Upload Files to the Release
         uses: softprops/action-gh-release@v2

.gitmodules

@@ -1,6 +1,6 @@
 [submodule "YRpp"]
 	path = YRpp
-	url = [email protected]:CnCNet/YRpp.git
+	url = [email protected]:Phobos-developers/YRpp.git
 [submodule "Private"]
 	path = Private
 	url = [email protected]:CnCNet/yrpp-spawner-private.git