Skip to content

Commit 052ce31

Browse files
author
Gerit Wagner
committed
assign_linter_messages: use object linter instead of parameter
1 parent ac53f2f commit 052ce31

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

search_query/ebscohost/parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,7 +477,7 @@ def parse(self) -> Query:
477477
except QuerySyntaxError as exc:
478478
raise exc
479479
finally:
480-
self.assign_linter_messages(query_parser.linter.messages, self.linter)
480+
self.assign_linter_messages(query_parser.linter.messages)
481481

482482
self.linter.check_status()
483483

search_query/parser_base.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -391,10 +391,10 @@ def resolve_reference(ref_nr: str) -> typing.Tuple[str, dict]:
391391

392392
return query_str, offset
393393

394-
def assign_linter_messages(self, parser_messages, linter) -> None: # type: ignore
394+
def assign_linter_messages(self, parser_messages) -> None: # type: ignore
395395
"""Assign linter messages to the appropriate query nodes."""
396-
if GENERAL_ERROR_POSITION not in linter.messages:
397-
linter.messages[GENERAL_ERROR_POSITION] = []
396+
if GENERAL_ERROR_POSITION not in self.linter.messages:
397+
self.linter.messages[GENERAL_ERROR_POSITION] = []
398398
for message in parser_messages:
399399
assigned = False
400400
if message["position"] != [(-1, -1)] and message["position"] != []:
@@ -404,14 +404,14 @@ def assign_linter_messages(self, parser_messages, linter) -> None: # type: igno
404404
<= message["position"][0][0]
405405
<= node["content_pos"][1]
406406
):
407-
if level not in linter.messages:
408-
linter.messages[level] = []
409-
linter.messages[level].append(message)
407+
if level not in self.linter.messages:
408+
self.linter.messages[level] = []
409+
self.linter.messages[level].append(message)
410410
assigned = True
411411
break
412412

413413
if not assigned:
414-
linter.messages[GENERAL_ERROR_POSITION].append(message)
414+
self.linter.messages[GENERAL_ERROR_POSITION].append(message)
415415

416416
@abstractmethod
417417
def parse(self) -> Query:

search_query/pubmed/parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def parse(self) -> Query:
343343
except QuerySyntaxError as exc:
344344
raise exc
345345
finally:
346-
self.assign_linter_messages(query_parser.linter.messages, self.linter)
346+
self.assign_linter_messages(query_parser.linter.messages)
347347

348348
self.linter.check_status()
349349

search_query/wos/parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def parse(self) -> Query:
432432
except QuerySyntaxError as exc:
433433
raise exc
434434
finally:
435-
self.assign_linter_messages(query_parser.linter.messages, self.linter)
435+
self.assign_linter_messages(query_parser.linter.messages)
436436
self.linter.check_status()
437437

438438
query.set_platform_unchecked(PLATFORM.WOS.value, silent=True)

0 commit comments

Comments
 (0)