use operator constants

Author: Gerit Wagner

search_query/query.py

@@ -79,13 +79,13 @@ def __init__(
     def selects(self, *, record_dict: dict) -> bool:
         """Indicates whether the query selects a given record."""
 
-        if self.value == "NOT":
+        if self.value == Operators.NOT:
             return not self.children[0].selects(record_dict=record_dict)
 
-        if self.value == "AND":
+        if self.value == Operators.AND:
             return all(x.selects(record_dict=record_dict) for x in self.children)
 
-        if self.value == "OR":
+        if self.value == Operators.OR:
             return any(x.selects(record_dict=record_dict) for x in self.children)
 
         assert not self.operator

search_query/serializer_pubmed.py

@@ -6,7 +6,7 @@
 
 from search_query.constants import PLATFORM
 from search_query.constants import PLATFORM_FIELD_MAP
-
+from search_query.constants import Operators
 if typing.TYPE_CHECKING:  # pragma: no
     from search_query.query import Query
 
@@ -41,7 +41,7 @@ def to_string_pubmed(node: Query) -> str:
 
         else:
             # node is operator node
-            if child.value == "NOT":
+            if child.value == Operators.NOT:
                 # current element is NOT Operator -> no parenthesis in PubMed
                 result = f"{result}{to_string_pubmed(child)}"
 
@@ -50,7 +50,7 @@ def to_string_pubmed(node: Query) -> str:
             else:
                 result = f"{result} {node.value} {to_string_pubmed(child)}"
 
-            if (child == node.children[-1]) & (child.value != "NOT"):
+            if (child == node.children[-1]) & (child.value != Operators.NOT):
                 result = f"{result})"
     return f"{result}"
 

search_query/serializer_wos.py

@@ -5,6 +5,7 @@
 import typing
 
 from search_query.constants import Fields
+from search_query.constants import Operators
 
 if typing.TYPE_CHECKING:  # pragma: no
     from search_query.query import Query
@@ -36,7 +37,7 @@ def to_string_wos(node: Query) -> str:
 
         else:
             # node is operator node
-            if child.value == "NOT":
+            if child.value == Operators.NOT:
                 # current element is NOT Operator -> no parenthesis in WoS
                 result = f"{result}{to_string_wos(child)}"
 
@@ -45,7 +46,7 @@ def to_string_wos(node: Query) -> str:
             else:
                 result = f"{result} {node.value} {to_string_wos(child)}"
 
-            if (child == node.children[-1]) & (child.value != "NOT"):
+            if (child == node.children[-1]) & (child.value != Operators.NOT):
                 result = f"{result})"
     return f"{result}"