Add pylint (generically) and force pytest

Author: CoMPaTech

.pre-commit-config.yaml

@@ -49,7 +49,7 @@ repos:
           - --quiet
           - --format=custom
           - --configfile=tests/bandit.yaml
-        files: ^(airos|tests)/.+\.py$
+        files: ^(airos|tests|script)/.+\.py$
   - repo: https://github.com/adrienverge/yamllint.git
     rev: v1.37.1
     hooks:
@@ -75,17 +75,30 @@ repos:
           - --py39-plus
           - --force
           - --keep-updates
-        files: ^(airos|tests)/.+\.py$
+        files: ^(airos|tests|script)/.+\.py$
   - repo: https://github.com/igorshubovych/markdownlint-cli
     rev: v0.45.0
     hooks:
       - id: markdownlint
   - repo: local
     hooks:
+      - id: pytest
+        name: "pytest"
+        entry: script/run-in-env.sh pytest
+        language: script
+        types: [python]
+        pass_filenames: false
+        files: ^(airos|tests|script)/.+\.py$
+      - id: pylint
+        name: "pylinting"
+        entry: script/run-in-env.sh pylint -j 0
+        language: script
+        types: [python]
+        files: ^(airos|tests|script)/.+\.py$
       - id: mypy
         name: mypy
         entry: script/run-in-env.sh mypy
         language: script
         require_serial: true
         types_or: [python, pyi]
-        files: ^(airos|tests|scripts)/.+\.(py|pyi)$
+        files: ^(airos|tests|script)/.+\.(py|pyi)$

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.2.10] - 2025-08-13
+
+### Changed
+
+- Maintenance chores
+- Added pylint and pytest (and applicable changes)
+
 ## [0.2.9] - 2025-08-12
 
 ### Changed

airos/airos8.py

@@ -193,7 +193,7 @@ async def login(self) -> bool:
             _LOGGER.info("Login task was cancelled")
             raise
 
-    def derived_data(self, response: dict[str, Any] = {}) -> dict[str, Any]:
+    def derived_data(self, response: dict[str, Any]) -> dict[str, Any]:
         """Add derived data to the device response."""
         derived: dict[str, Any] = {
             "station": False,

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name            = "airos"
-version         = "0.2.9"
+version         = "0.2.10"
 license         = "MIT"
 description     = "Ubiquity airOS module(s) for Python 3."
 readme          = "README.md"

script/generate_ha_fixture.py

@@ -42,13 +42,13 @@ def generate_airos_fixtures() -> None:
             _LOGGER.info("Processing '%s'...", filename)
 
             try:
-                with open(base_fixture_path) as source:
+                with open(base_fixture_path, encoding="utf-8") as source:
                     source_data = json.loads(source.read())
 
                 derived_data = AirOS.derived_data(None, source_data)  # type: ignore[arg-type]
                 new_data = AirOSData.from_dict(derived_data)
 
-                with open(new_fixture_path, "w") as new:
+                with open(new_fixture_path, "w", encoding="utf-8") as new:
                     json.dump(new_data.to_dict(), new, indent=2, sort_keys=True)
 
                 _LOGGER.info("Successfully created '%s'", new_filename)

script/mashumaro-step-debug.py

@@ -6,11 +6,11 @@
 import sys
 from typing import Any
 
-current_script_dir = os.path.dirname(os.path.abspath(__file__))
-project_root_dir = os.path.abspath(os.path.join(current_script_dir, os.pardir))
+_current_script_dir = os.path.dirname(os.path.abspath(__file__))
+_project_root_dir = os.path.abspath(os.path.join(_current_script_dir, os.pardir))
 
-if project_root_dir not in sys.path:
-    sys.path.append(project_root_dir)
+if _project_root_dir not in sys.path:
+    sys.path.append(_project_root_dir)
 
 from airos.data import AirOS8Data, Interface, Remote, Station, Wireless  # noqa: E402
 
@@ -31,7 +31,7 @@ def main() -> None:
         sys.path.append(project_root_dir)
 
     # Load the JSON data
-    with open(sys.argv[1]) as f:
+    with open(sys.argv[1], encoding="utf-8") as f:
         data = json.loads(f.read())
 
     try:
@@ -65,7 +65,6 @@ def main() -> None:
 
         _LOGGER.info("  -> Checking list of Interface objects...")
         interfaces = data["interfaces"]
-        interface_obj_list = []  # noqa: F841
         for i, interface_data in enumerate(interfaces):
             _LOGGER.info("    -> Checking Interface object at index %s...", i)
             _LOGGER.info("         Interface should be %s.", interface_data["ifname"])

tests/conftest.py

@@ -10,6 +10,8 @@
 
 import aiohttp
 
+# pylint: disable=redefined-outer-name, unnecessary-default-type-args
+
 
 @pytest.fixture
 def base_url() -> str:

tests/test_discovery.py

@@ -15,6 +15,8 @@
 from airos.exceptions import AirOSDiscoveryError, AirOSEndpointError, AirOSListenerError
 import pytest
 
+# pylint: disable=redefined-outer-name
+
 
 # Helper to load binary fixture
 async def _read_binary_fixture(fixture_name: str) -> bytes: