Add missing Litebeam 5AC options #45
Conversation
WalkthroughThis change updates the project version to 0.2.4, adds a changelog entry describing new LiteBeam 5AC options, and extends enums and type annotations in the data model to support LiteBeam 5AC devices. Specifically, new enum members are introduced and a dataclass attribute is made nullable. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Host (Dataclass)
participant IeeeMode (Enum)
participant WirelessMode (Enum)
User->>IeeeMode: Access enum members (_11ACVHT80, _11ACVHT40, _11ACVHT20)
User->>WirelessMode: Access enum members (PTP_ACCESSPOINT, PTMP_ACCESSPOINT, PTP_STATION)
User->>Host: Create Host, set height (int or None)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 93.12% 93.14% +0.01%
==========================================
Files 8 8
Lines 1076 1079 +3
==========================================
+ Hits 1002 1005 +3
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
airos/data.py (1)
38-41: Enum additions look good – keep an eye on the leading underscoreThe extra IEEE modes (
_11ACVHT40,_11ACVHT20) are consistent with the pre-existing_11ACVHT80, so no functional issue.
Just note that leading underscores may hide these members from some auto-generated docs ordir()listings.CHANGELOG.md (1)
5-10: Changelog entry OK – minor categorisation nitpickThe LiteBeam 5AC options are new capabilities, so you could place them under an “Added” section instead of “Changed” for slightly clearer semantics. Totally optional.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)airos/data.py(2 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (3)
pyproject.toml (1)
7-7: No runtime__version__constant detected – no further action needed
I ran a search across all.pyfiles and did not find any hard-coded__version__definitions. Since you’re not exposing a manual__version__in your package, you can rely on tools likeimportlib.metadata(orpkg_resources) to read the bumped version frompyproject.tomlat runtime.airos/data.py (2)
47-49: New wireless mode constant added
PTMP_ACCESSPOINTcovers the multi-point AP case and cleanly extends the enum. No concerns.
94-95: Optionalheightaccepted, consider mirroring inRemoteAllowing
NoneforHost.heightmatches field behaviour on LiteBeam 5AC devices.
Remote.height(Line 256) is stillint; if the remote side can also reportnull, alignment would avoid future deserialization errors.Would you verify a LiteBeam trace for the
remote.heightfield? If it can benull, applying the diff below keeps the model symmetric:- height: int + height: int | None
|
Summary by CodeRabbit