* Fixed symlink error and shellcheck

Author: Samuel Vandamme

install.sh

@@ -19,32 +19,32 @@ if [ -z ${COSCALE_APPID+x} ] || [ -z ${COSCALE_TOKEN+x} ]; then
     # Check command arguments
     if [ -z ${COSCALE_APPID+x} ]; then
         echo "Please enter your app id:"
-        read -e COSCALE_APPID
+        read -e -r COSCALE_APPID
     fi
     echo
 
     if [ -z ${COSCALE_TOKEN+x} ]; then
         echo "Please enter your access token:"
-        read -e COSCALE_TOKEN
+        read -e -r COSCALE_TOKEN
     fi
     echo
 fi
 
 # Detect operation system
 echo "### Detecting operating system"
 echo
-os=`uname -o | awk '{split($0,a,"/"); print tolower(a[2])}'`
+os=$(uname -o | awk '{split($0,a,"/"); print tolower(a[2])}')
 echo "Operation system: $os"
 echo
 
 # Fetch latest release list from Github
 echo
 echo "## Getting latest release information"
 echo
-github_data=`curl -s -L https://api.github.com/repos/CoScale/coscale-cli/releases/latest | grep "browser_download_url" | awk '{ print $2; }' | sed 's/"//g'`
+github_data=$(curl -s -L https://api.github.com/repos/CoScale/coscale-cli/releases/latest | grep "browser_download_url" | awk '{ print $2; }' | sed 's/"//g')
 
 # Select correct release
-release=`echo "$github_data" | grep $os`
+release=`echo "$github_data" | grep "$os"`
 echo "### Latest release: $release"
 
 # Start install
@@ -67,7 +67,7 @@ echo
 
 # Create symlink from /usr/bin/coscale-cli to /opt/coscale/cli/coscale-cli
 echo "### Creating symlink"
-ln -v -S /usr/bin/coscale-cli /opt/coscale/cli/coscale-cli
+ln -v -s /usr/bin/coscale-cli /opt/coscale/cli/coscale-cli
 echo
 
 # Create config