add Server-Authoritative movement system

If your plugins depends on legacy movement packets and stopped working, set ServerAuthoritativeMovement to false in server.conf.

Author: laz1444

src/MiNET/MiNET.Console/server.conf

@@ -89,6 +89,9 @@ ForceResourcePacks=false
 # ======================================= ADVANCED =======================================
 # Change this only on purpose. Don't touch if you are not sure.
 
+#Use Server-Authoritative movement system.
+ServerAuthoritativeMovement=true
+
 #Should server check if player is logged in Xbox Live? In public server this should be true to avoid fake usernames.
 ForceXBLAuthentication=true
 
@@ -122,7 +125,7 @@ ResourceDirectory=ResourcePacks
 
 # REGEX docs! https://msdn.microsoft.com/en-us/library/az24scfc(v=vs.110).aspx
 #TracePackets.Include=Mcpe.*
-TracePackets.Exclude=McpeWrapper|McpeBatch|McpeFullChunkData|McpeMoveEntity|McpeMoveEntityDelta|McpeUpdateBlock
+TracePackets.Exclude=McpeWrapper|McpeBatch|McpeFullChunkData|McpeMoveEntity|McpeMoveEntityDelta|McpeUpdateBlock|McpePlayerAuthInput
 TracePackets.Verbosity=0
 TracePackets.Verbosity.McpeClientToServerHandshake=0
 TracePackets.Verbosity.McpeAddEntity=0

src/MiNET/MiNET/Net/AuthInputFlags.cs

@@ -5,122 +5,57 @@ namespace MiNET.Net;
 [Flags]
 public enum AuthInputFlags : long
 {
-	/// <summary>
-	/// Pressing the "fly up" key when using touch.
-	/// </summary>
 	Ascend = 1L <<0,
-	/// <summary>
-	///  Pressing the "fly down" key when using touch. 
-	/// </summary>
 	Descend = 1L <<1,
-	/// <summary>
-	/// Pressing (and optionally holding) the jump key (while not flying).
-	/// </summary>
 	NorthJump = 1L <<2,
-	/// <summary>
-	///  Pressing (and optionally holding) the jump key (including while flying).
-	/// </summary>
 	JumpDown = 1L <<3,
-	/// <summary>
-	/// Pressing (and optionally holding) the sprint key (typically the CTRL key). Does not include double-pressing the forward key. 
-	/// </summary>
 	SprintDown = 1L <<4,
-	/// <summary>
-	///  Pressing (and optionally holding) the fly button ONCE when in flight mode when using touch. This has no obvious use.
-	/// </summary>
 	ChangeHeight = 1L <<5,
-	/// <summary>
-	/// Pressing (and optionally holding) the jump key (including while flying), and also auto-jumping. 
-	/// </summary>
 	Jumping = 1L <<6,
-	/// <summary>
-	/// Auto-swimming upwards while pressing forwards with auto-jump enabled.
-	/// </summary>
 	AutoJumpingInWater = 1L <<7,
-	/// <summary>
-	/// Sneaking, and pressing the "fly down" key or "sneak" key (including while flying).
-	/// </summary>
 	Sneaking = 1L <<8,
-	/// <summary>
-	///  Pressing (and optionally holding) the sneak key (including while flying). This includes when the sneak button is toggled ON with touch controls. 
-	/// </summary>
 	SneakDown = 1L <<9,
-	
-	/// <summary>
-	/// Pressing the forward key (typically W on keyboard).
-	/// </summary>
 	WalkForwards = 1L <<10,
-	/// <summary>
-	/// Pressing the backward key (typically S on keyboard).
-	/// </summary>
 	WalkBackwards = 1L <<11,
-	/// <summary>
-	/// Pressing the left key (typically A on keyboard).
-	/// </summary>
 	StrafeLeft = 1L <<12,
-	/// <summary>
-	///  Pressing the right key (typically D on keyboard). 
-	/// </summary>
 	StrafeRight = 1L <<13,
-	
 	UpLeft = 1L <<14,
 	UpRight = 1L <<15,
-	
-	/// <summary>
-	/// Client wants to go upwards. Sent when Ascend or Jump is pressed, irrespective of whether flight is enabled
-	/// </summary>
 	WantUp = 1L <<16,
-	
-	/// <summary>
-	/// Client wants to go downwards. Sent when Descend or Sneak is pressed, irrespective of whether flight is enabled
-	/// </summary>
 	WantDown = 1L <<17,
 	WantDownSlow = 1L <<18,
 	WantUpSlow = 1L <<19,
-	
 	Sprinting = 1L <<20,
 	AscendBlock = 1L <<21,
 	DescendBlock = 1L <<22,
-	
-	/// <summary>
-	///  Toggling the sneak button on touch when the button enters the "enabled" state. 
-	/// </summary>
 	SneakToggleDown = 1L <<23,
 	PersistSneak = 1L <<24,
-	
-	/// <summary>
-	///		 Pressing the sprint toggle while NOT sprinting.
-	/// </summary>
 	StartSprinting = 1L <<25,
-	
-	/// <summary>
-	///		 Pressing the sprint toggle while sprinting.
-	/// </summary>
 	StopSprinting = 1L <<26,
-	
-	/// <summary>
-	///		 Pressing the sneak toggle while NOT sneaking.
-	/// </summary>
 	StartSneaking = 1L <<27,
-	
-	/// <summary>
-	///		 Pressing the sneak toggle while sneaking.
-	/// </summary>
 	StopSneaking = 1L <<28,
-	
 	StartSwimming = 1L <<29,
 	StopSwimming = 1L <<30,
-	
-	/// <summary>
-	///  Initiating a new jump. Sent every time the client leaves the ground due to jumping, including auto jumps.
-	/// </summary>
 	StartJumping = 1L <<31,
 	StartGliding = 1L <<32,
 	StopGliding = 1L <<33,
-	
 	PerformItemInteraction = 1L <<34,
 	PerformBlockActions = 1L <<35,
 	PerformItemStackRequest = 1L <<36,
 	HandledTeleport = 1L << 37,
-	Emoting = 1L << 38
+	Emoting = 1L << 38,
+	MissedSwing = 1L << 39,
+	StartCrawling = 1L << 40,
+	StopCrawling = 1L << 41,
+	StartFying = 1L << 42,
+	StopFying = 1L << 43,
+	IsInClientPredictedVehicle = 1L << 45,
+	PaddlingLeft = 1L << 46,
+	PaddlingRight = 1L << 47,
+	BlockBreakingDelayEnabled = 1L << 48,
+	HorizontalCollision = 1L << 49,
+	VerticalCollision = 1L << 50,
+	DownLeft = 1L << 51,
+	DownRight = 1L << 52,
+	INPUT_NUM = 1L << 53
 }

src/MiNET/MiNET/Net/BedrockMessageHandler.cs

@@ -246,6 +246,9 @@ private void HandleBedrockMessage(IMcpeMessageHandler handler, Packet message)
 				case McpeAnvilDamage msg:
 					handler.HandleMcpeAnvilDamage(msg);
 					break;
+				case McpePlayerAuthInput msg:
+					handler.HandleMcpePlayerAuthInput(msg);
+					break;
 
 				default:
 				{

src/MiNET/MiNET/Net/MCPE Protocol.cs

@@ -10608,7 +10608,7 @@ public partial class McpeEmotePacket : Packet<McpeEmotePacket>
 		public string platformId; // = null;
 		public string emoteId; // = null;
 		public byte flags; // = null;
-		public long tick; // = null;
+		public uint tick; // = null;
 
 		public McpeEmotePacket()
 		{
@@ -10624,10 +10624,10 @@ protected override void EncodePacket()
 
 			WriteUnsignedVarLong(runtimeEntityId);
 			Write(emoteId);
+			WriteUnsignedVarInt(tick);
 			Write(xuid);
 			Write(platformId);
 			Write(flags);
-			Write(tick);
 
 			AfterEncode();
 		}
@@ -10643,10 +10643,10 @@ protected override void DecodePacket()
 
 			runtimeEntityId = ReadUnsignedVarLong();
 			emoteId = ReadString();
+			tick = ReadUnsignedVarInt();
 			xuid = ReadString();
 			platformId = ReadString();
 			flags = ReadByte();
-			tick = ReadLong();
 
 			AfterDecode();
 		}
@@ -10662,7 +10662,7 @@ protected override void ResetPacket()
 			xuid = default(string);
 			platformId = default(string);
 			emoteId = default(string);
-			tick = default(long);
+			tick = default(uint);
 			flags = default(byte);
 		}
 

src/MiNET/MiNET/Net/McpePlayerAuthInput.cs

@@ -1,79 +1,30 @@
-using System.Numerics;
+using System.Collections.Generic;
+using System.Numerics;
+using MiNET.Utils.Vectors;
 
 namespace MiNET.Net;
 
 public partial class McpePlayerAuthInput : Packet<McpePlayerAuthInput>
 {
-	/// <summary>
-	///		Pitch and Yaw hold the rotation that the player reports it has.
-	/// </summary>
-	public float Pitch;
-	
-	/// <summary>
-	/// Pitch and Yaw hold the rotation that the player reports it has.
-	/// </summary>
-	public float Yaw;
-	
-	/// <summary>
-	///		Pitch and Yaw hold the rotation that the player reports it has.
-	/// </summary>
-	public float HeadYaw;
-	
-	/// <summary>
-	///		 Position holds the position that the player reports it has.
-	/// </summary>
-	public Vector3 Position;
-	
-	/// <summary>
-	///		MoveVector is a Vec2 that specifies the direction in which the player moved, as a combination of X/Z
-	///		values which are created using the WASD/controller stick state.
-	/// </summary>
-	public Vector2 MoveVector;
-	
-	/// <summary>
-	///		InputData is a combination of bit flags that together specify the way the player moved last tick.
-	/// </summary>
+	public PlayerLocation Position;
 	public AuthInputFlags InputFlags;
-	
-	/// <summary>
-	///  InputMode specifies the way that the client inputs data to the screen.
-	/// </summary>
 	public PlayerInputMode InputMode;
-	
-	/// <summary>
-	/// PlayMode specifies the way that the player is playing. 
-	/// </summary>
 	public PlayerPlayMode PlayMode;
-
-	/// <summary>
-	///		InteractionModel is a constant representing the interaction model the player is using. 
-	/// </summary>
 	public PlayerInteractionModel InteractionModel;
-	
-	/// <summary>
-	///		GazeDirection is the direction in which the player is gazing, when the PlayMode is PlayModeReality: In other words, when the player is playing in virtual reality.
-	/// </summary>
 	public Vector3 GazeDirection;
-	
-	/// <summary>
-	///		Tick is the server tick at which the packet was sent. It is used in relation to CorrectPlayerMovePrediction.
-	/// </summary>
 	public long Tick;
-	
-	/// <summary>
-	///		Delta was the delta between the old and the new position.
-	/// </summary>
 	public Vector3 Delta;
+	public PlayerBlockActions Actions;
 
 	public Vector2 AnalogMoveVector;
 
 	partial void AfterDecode()
 	{
-		Pitch = ReadFloat();
-		Yaw = ReadFloat();
-		Position = ReadVector3();
-		MoveVector = ReadVector2();
-		HeadYaw = ReadFloat();
+		var Rot = ReadVector2();
+		var Pos = ReadVector3();
+		ReadVector2(); // what move vector?
+		var HeadYaw = ReadFloat();
+		Position = new PlayerLocation(Pos.X, Pos.Y, Pos.Z, HeadYaw, Rot.Y, Rot.X);
 		InputFlags = (AuthInputFlags)ReadUnsignedVarLong();
 		InputMode = (PlayerInputMode)ReadUnsignedVarInt();
 		PlayMode = (PlayerPlayMode)ReadUnsignedVarInt();
@@ -87,24 +38,19 @@ partial void AfterDecode()
 		Tick = ReadUnsignedVarLong();
 		Delta = ReadVector3();
 
-		if ((InputFlags & AuthInputFlags.PerformItemInteraction) != 0)
+		if ((InputFlags & AuthInputFlags.PerformBlockActions) != 0)
 		{
-			
+			Actions = ReadPlayerBlockActions();
 		}
 
 		AnalogMoveVector = ReadVector2();
 	}
 
 	partial void AfterEncode()
 	{
-		Write(Pitch);
-		Write(Yaw);
-		Write(Position);
-		Write(MoveVector);
-		Write(HeadYaw);
 		WriteUnsignedVarLong((long)InputFlags);
 		WriteUnsignedVarInt((uint)InputMode);
-		WriteUnsignedVarInt((uint) PlayMode);
+		WriteUnsignedVarInt((uint)PlayMode);
 		WriteUnsignedVarInt((uint)InteractionModel);
 
 		if (PlayMode == PlayerPlayMode.VR)
@@ -117,13 +63,10 @@ partial void AfterEncode()
 		Write(AnalogMoveVector);
 	}
 
-	/// <inheritdoc />
 	public override void Reset()
 	{
 		base.Reset();
-		Pitch = Yaw = HeadYaw = 0f;
-		MoveVector = Vector2.Zero;
-		Position = Vector3.Zero;
+		Position = default(PlayerLocation);
 		InputFlags = 0;
 		InputMode = PlayerInputMode.Mouse;
 		PlayMode = PlayerPlayMode.Normal;
@@ -160,4 +103,16 @@ public enum PlayerInteractionModel
 		Crosshair = 1,
 		Classic = 2
 	}
+
+	public class PlayerBlockActions
+	{
+		public List<PlayerBlockActionData> PlayerBlockAction = new List<PlayerBlockActionData>();
+	}
+
+	public class PlayerBlockActionData
+	{
+		public PlayerAction PlayerActionType;
+		public BlockCoordinates BlockCoordinates;
+		public int Facing;
+	}
 }

src/MiNET/MiNET/Net/Packet.cs

@@ -49,6 +49,7 @@
 using MiNET.Utils.Skins;
 using MiNET.Utils.Vectors;
 using Newtonsoft.Json;
+using static MiNET.Net.McpePlayerAuthInput;
 
 namespace MiNET.Net
 {
@@ -3884,6 +3885,26 @@ public void Write(EmoteIds Ids)
 			}
 		}
 
+		public PlayerBlockActions ReadPlayerBlockActions()
+		{
+			PlayerBlockActions actions = new PlayerBlockActions();
+			var actionCount = ReadSignedVarInt();
+			for (int i = 0; i < actionCount; i++)
+			{
+				var actionType = (PlayerAction) ReadSignedVarInt();
+				if (actionType is PlayerAction.StartBreak or PlayerAction.AbortBreak or PlayerAction.StopBreak or PlayerAction.Breaking or PlayerAction.PredictDestroyBlock or PlayerAction.ContinueDestroyBlock)
+				{
+					actions.PlayerBlockAction.Add(new PlayerBlockActionData() { PlayerActionType = actionType, BlockCoordinates = new BlockCoordinates(ReadSignedVarInt(), ReadSignedVarInt(), ReadSignedVarInt()), Facing = ReadVarInt() });
+				}
+				else
+				{
+					actions.PlayerBlockAction.Add(new PlayerBlockActionData() { PlayerActionType = actionType});
+
+				}
+			}
+			return actions;
+		}
+
 		public fogStack Read()
 		{
 			fogStack stack = new fogStack();