fixup: dependency from git, remove git submodule

Author: not-matthias

.gitmodules

@@ -1,3 +0,0 @@
-[submodule "core/instrument-hooks"]
-	path = core/instrument-hooks
-	url = https://github.com/CodSpeedHQ/instrument-hooks

MODULE.bazel

@@ -1 +1,8 @@
 bazel_dep(name = "rules_cc", version = "0.0.17")
+bazel_dep(name = "instrument_hooks", version = "1.0.0")
+
+git_override(
+    module_name = "instrument_hooks",
+    commit = "a2971f00dd2a9ce475d4f28ca2a1d7e4ec41eefd",
+    remote = "https://github.com/CodSpeedHQ/instrument-hooks",
+)

core/BUILD

@@ -8,25 +8,6 @@ config_setting(
     constraint_values = ["@platforms//os:windows"],
 )
 
-# Define the instrument-hooks library separately to apply warning suppressions
-cc_library(
-    name = "instrument_hooks",
-    srcs = ["instrument-hooks/dist/core.c"],
-    hdrs = glob(["instrument-hooks/includes/*.h"]),
-    includes = ["instrument-hooks/includes"],
-    copts = select({
-        ":windows": [
-            "/wd4101",  # unreferenced local variable (equivalent to -Wno-unused-variable)
-            "/wd4189",  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
-            "/wd4100",  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
-        ],
-        "//conditions:default": [
-            "-Wno-unused-variable",
-            "-Wno-unused-parameter",
-            "-Wno-unused-but-set-variable",
-        ],
-    }),
-)
 
 # Define the codspeed library
 cc_library(
@@ -45,7 +26,7 @@ cc_library(
         ":walltime_mode": ["CODSPEED_ENABLED", "CODSPEED_WALLTIME"],
         "//conditions:default": [],
     }),
-    deps = [":instrument_hooks"],
+    deps = ["//core/instrument-hooks:instrument_hooks"],
     visibility = ["//visibility:public"],
 )
 

core/CMakeLists.txt

@@ -10,37 +10,14 @@ set(CMAKE_CXX_STANDARD_REQUIRED True)
 
 # Add the include directory
 include_directories(include)
-include_directories(instrument-hooks/includes)
 
-# Add the library
-add_library(
+include(FetchContent)
+FetchContent_Declare(
     instrument_hooks
-    instrument-hooks/dist/core.c
+    GIT_REPOSITORY https://github.com/CodSpeedHQ/instrument-hooks/
+    GIT_TAG a2971f00dd2a9ce475d4f28ca2a1d7e4ec41eefd
 )
-
-# Suppress warnings for the instrument_hooks library
-if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
-    target_compile_options(
-        instrument_hooks
-        PRIVATE
-        -Wno-maybe-uninitialized
-        -Wno-unused-variable
-        -Wno-unused-parameter
-        -Wno-unused-but-set-variable
-        -Wno-type-limits
-    )
-elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
-    target_compile_options(
-        instrument_hooks
-        PRIVATE
-        /wd4101  # unreferenced local variable (equivalent to -Wno-unused-variable)
-        /wd4189  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
-        /wd4100  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
-        /wd4245  # signed/unsigned mismatch
-        /wd4132  # const object should be initialized
-        /wd4146  # unary minus operator applied to unsigned type
-    )
-endif()
+FetchContent_MakeAvailable(instrument_hooks)
 
 # Add the main library
 add_library(
@@ -61,7 +38,6 @@ add_compile_definitions(CODSPEED_VERSION="${CODSPEED_VERSION}")
 target_include_directories(
     codspeed
     PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
-           $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/instrument-hooks/includes>
 )
 
 # Disable valgrind compilation errors

core/instrument-hooks

@@ -28,14 +28,11 @@ python.toolchain(
 )
 python.toolchain(python_version = "3.13")
 
-pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip", dev_dependency = True)
-pip.parse(
-    hub_name = "tools_pip_deps",
-    python_version = "3.9",
-    requirements_lock = "//tools:requirements.txt",
+# -- bazel_dep definitions -- #
+
+local_path_override(
+    module_name = "instrument_hooks",
+    path = "../core/instrument-hooks",
 )
-use_repo(pip, "tools_pip_deps")
 
-# -- bazel_dep definitions -- #
 
-bazel_dep(name = "nanobind_bazel", version = "2.5.0", dev_dependency = True)