fix: expose instrument-hooks via extension

Author: not-matthias

MODULE.bazel

@@ -1,8 +1,5 @@
 bazel_dep(name = "rules_cc", version = "0.0.17")
-bazel_dep(name = "instrument_hooks", version = "1.0.0")
+bazel_dep(name = "platforms", version = "0.0.10")
 
-git_override(
-    module_name = "instrument_hooks",
-    commit = "42ed74076c697c2f06c5ac81a84ccee983d7f140",
-    remote = "https://github.com/CodSpeedHQ/instrument-hooks",
-)
+# Fetch instrument_hooks via module extension (it doesn't have MODULE.bazel)
+use_repo(use_extension("//third_party:extensions.bzl", "instrument_hooks"), "instrument_hooks")

core/BUILD

@@ -8,35 +8,6 @@ config_setting(
     constraint_values = ["@platforms//os:windows"],
 )
 
-# Instrument-hooks library with warning suppressions
-cc_library(
-    name = "instrument_hooks",
-    srcs = ["instrument-hooks/dist/core.c"],
-    hdrs = glob(["instrument-hooks/includes/*.h"]),
-    includes = ["instrument-hooks/includes"],
-    copts = select({
-        ":windows": [
-            "/wd4101",  # unreferenced local variable (equivalent to -Wno-unused-variable)
-            "/wd4189",  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
-            "/wd4100",  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
-            "/wd4245",  # signed/unsigned mismatch
-            "/wd4132",  # const object should be initialized
-            "/wd4146",  # unary minus operator applied to unsigned type
-        ],
-        "//conditions:default": [
-            "-Wno-maybe-uninitialized",
-            "-Wno-unused-variable",
-            "-Wno-unused-parameter",
-            "-Wno-unused-but-set-variable",
-            "-Wno-type-limits",
-            "-Wno-format",
-            "-Wno-format-security",
-        ],
-    }),
-    visibility = ["//visibility:public"],
-)
-
-
 # Define the codspeed library
 cc_library(
     name = "codspeed",
@@ -54,7 +25,7 @@ cc_library(
         ":walltime_mode": ["CODSPEED_ENABLED", "CODSPEED_WALLTIME"],
         "//conditions:default": [],
     }),
-    deps = [":instrument_hooks"],
+    deps = ["@instrument_hooks//:instrument_hooks"],
     visibility = ["//visibility:public"],
 )
 

core/instrument-hooks

@@ -0,0 +1,7 @@
+# This package contains BUILD files and extensions for third-party dependencies
+# that don't have their own Bazel configuration
+
+exports_files([
+    "instrument_hooks.BUILD",
+    "extensions.bzl",
+])

third_party/BUILD

@@ -0,0 +1,20 @@
+"""Bazel module extensions for codspeed-cpp dependencies."""
+
+load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
+
+def _instrument_hooks_impl(module_ctx):
+    git_repository(
+        name = "instrument_hooks",
+        remote = "https://github.com/CodSpeedHQ/instrument-hooks",
+        commit = "b1e401a4d031ad308edb22ed59a52253a1ebe924",
+        build_file = Label("//third_party:instrument_hooks.BUILD"),
+    )
+    return module_ctx.extension_metadata(
+        reproducible = True,
+        root_module_direct_deps = ["instrument_hooks"],
+        root_module_direct_dev_deps = [],
+    )
+
+instrument_hooks = module_extension(
+    implementation = _instrument_hooks_impl,
+)

third_party/extensions.bzl

@@ -0,0 +1,34 @@
+load("@rules_cc//cc:defs.bzl", "cc_library")
+
+config_setting(
+    name = "windows",
+    constraint_values = ["@platforms//os:windows"],
+)
+
+# Instrument-hooks library with warning suppressions
+cc_library(
+    name = "instrument_hooks",
+    srcs = ["dist/core.c"],
+    hdrs = glob(["includes/*.h"]),
+    includes = ["includes"],
+    copts = select({
+        ":windows": [
+            "/wd4101",  # unreferenced local variable
+            "/wd4189",  # local variable is initialized but not referenced
+            "/wd4100",  # unreferenced formal parameter
+            "/wd4245",  # signed/unsigned mismatch
+            "/wd4132",  # const object should be initialized
+            "/wd4146",  # unary minus operator applied to unsigned type
+        ],
+        "//conditions:default": [
+            "-Wno-maybe-uninitialized",
+            "-Wno-unused-variable",
+            "-Wno-unused-parameter",
+            "-Wno-unused-but-set-variable",
+            "-Wno-type-limits",
+            "-Wno-format",
+            "-Wno-format-security",
+        ],
+    }),
+    visibility = ["//visibility:public"],
+)