fixup: add windows strict warnings

Author: not-matthias

core/BUILD

@@ -23,6 +23,12 @@ config_setting(
     flag_values = {":strict_warnings": "on"},
 )
 
+config_setting(
+    name = "windows_strict_warnings",
+    constraint_values = ["@platforms//os:windows"],
+    flag_values = {":strict_warnings": "on"},
+)
+
 # IMPORTANT: Keep in sync with instrument-hooks/ci.yml (COMMON_CFLAGS)
 instrument_hooks_cflags = [
     "-Wno-format",
@@ -37,21 +43,24 @@ instrument_hooks_cflags = [
     "-Wno-unused-function",
 ]
 
+instrument_hooks_cflags_windows = [
+    "/wd4101",  # unreferenced local variable (equivalent to -Wno-unused-variable)
+    "/wd4189",  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
+    "/wd4100",  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
+    "/wd4245",  # signed/unsigned mismatch
+    "/wd4132",  # const object should be initialized
+    "/wd4146",  # unary minus operator applied to unsigned type
+]
+
 # Instrument-hooks library with warning suppressions
 cc_library(
     name = "instrument_hooks",
     srcs = ["instrument-hooks/dist/core.c"],
     hdrs = glob(["instrument-hooks/includes/*.h"]),
     includes = ["instrument-hooks/includes"],
     copts = select({
-        ":windows": [
-            "/wd4101",  # unreferenced local variable (equivalent to -Wno-unused-variable)
-            "/wd4189",  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
-            "/wd4100",  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
-            "/wd4245",  # signed/unsigned mismatch
-            "/wd4132",  # const object should be initialized
-            "/wd4146",  # unary minus operator applied to unsigned type
-        ],
+        ":windows_strict_warnings": ["/W4","/WX"] + instrument_hooks_cflags_windows,
+        ":windows": instrument_hooks_cflags_windows,
         ":strict_warnings_enabled": ["-Wall", "-Werror"] + instrument_hooks_cflags,
         "//conditions:default": instrument_hooks_cflags,
     }),