chore(core): prevent building tests if there are warnings

This way we can get early warnings in our CI without disrupting
downstream users by adding -Wall -Werror etc if they do not wish to do
so.

Author: GuillaumeLagrange

core/test/CMakeLists.txt

@@ -18,5 +18,12 @@ target_link_libraries(unit_tests
   GTest::gtest_main
 )
 
+# Treat warnings as errors for tests to catch issues early
+if(MSVC)
+  target_compile_options(unit_tests PRIVATE /W4 /WX)
+elseif(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+  target_compile_options(unit_tests PRIVATE -Wall -Wextra -Werror)
+endif()
+
 include(GoogleTest)
 gtest_discover_tests(unit_tests)

examples/google_benchmark_bazel/BUILD.bazel

@@ -1,7 +1,15 @@
+config_setting(
+    name = "windows",
+    constraint_values = ["@platforms//os:windows"],
+)
+
 cc_binary(
     name = "my_benchmark",
     srcs = glob(["*.cpp", "*.hpp"]),
-    copts = ["-Wall", "-Wextra", "-Werror"],
+    copts = select({
+        ":windows": ["/std:c++17", "/W4", "/WX"],
+        "//conditions:default": ["-Wall", "-Wextra", "-Werror"],
+    }),
     deps = [
         "//google_benchmark:benchmark",
     ],

examples/google_benchmark_cmake/CMakeLists.txt

@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.12)
 include(FetchContent)
 
-project(codspeed_picobench_compat VERSION 0.0.0 LANGUAGES CXX)
+project(codspeed_google_benchmark_example VERSION 0.0.0 LANGUAGES CXX)
 
 # Treat warnings as errors
 if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")

google_benchmark/include/benchmark/benchmark.h

@@ -185,10 +185,10 @@ BENCHMARK(BM_test)->Unit(benchmark::kMillisecond);
 
 #ifdef CODSPEED_ENABLED
 #include <codspeed.h>
-#include <measurement.hpp>
 
 #include <filesystem>
-#endif // CODSPEED_ENABLED
+#include <measurement.hpp>
+#endif  // CODSPEED_ENABLED
 
 #if defined(_MSC_VER)
 #include <intrin.h>  // for _ReadWriteBarrier
@@ -947,7 +947,7 @@ class BENCHMARK_EXPORT BENCHMARK_INTERNAL_CACHELINE_ALIGNED State {
  public:
   const IterationCount max_iterations;
 #ifdef CODSPEED_INSTRUMENTATION
-  codspeed::CodSpeed *codspeed_;
+  codspeed::CodSpeed* codspeed_;
 #endif
 
  private:
@@ -970,11 +970,11 @@ class BENCHMARK_EXPORT BENCHMARK_INTERNAL_CACHELINE_ALIGNED State {
         internal::ThreadTimer* timer, internal::ThreadManager* manager,
         internal::PerfCountersMeasurement* perf_counters_measurement,
         ProfilerManager* profiler_manager
-  #ifdef CODSPEED_INSTRUMENTATION
+#ifdef CODSPEED_INSTRUMENTATION
         ,
-        codspeed::CodSpeed *codspeed = NULL
-  #endif
-        );
+        codspeed::CodSpeed* codspeed = NULL
+#endif
+  );
 
   void StartKeepRunning();
   // Implementation of KeepRunning() and KeepRunningBatch().
@@ -1609,12 +1609,12 @@ class Fixture : public internal::Benchmark {
 #ifdef CODSPEED_ENABLED
 
 #define BENCHMARK_PRIVATE_DECLARE_F(BaseClass, Method)        \
-    STATIC_NAMESPACE_STRING(ns_##BaseClass##_##Method);         \
+  STATIC_NAMESPACE_STRING(ns_##BaseClass##_##Method);         \
   class BaseClass##_##Method##_Benchmark : public BaseClass { \
    public:                                                    \
     BaseClass##_##Method##_Benchmark() {                      \
       this->SetName(CUR_FILE + ns_##BaseClass##_##Method +    \
-                    #Method "[" #BaseClass "]");                  \
+                    #Method "[" #BaseClass "]");              \
     }                                                         \
                                                               \
    protected:                                                 \
@@ -1660,7 +1660,7 @@ class Fixture : public internal::Benchmark {
     void BenchmarkCase(::benchmark::State&) override;                      \
   };
 
-#else // CODSPEED_ENABLED undefined:
+#else  // CODSPEED_ENABLED undefined:
 
 #define BENCHMARK_PRIVATE_DECLARE_F(BaseClass, Method)        \
   class BaseClass##_##Method##_Benchmark : public BaseClass { \