fix: build warnings for instrument-hooks

Author: not-matthias

core/CMakeLists.txt

@@ -12,21 +12,34 @@ set(CMAKE_CXX_STANDARD_REQUIRED True)
 include_directories(include)
 include_directories(instrument-hooks/includes)
 
-# Add the library
+# Create separate instrument_hooks library with warning suppressions
+add_library(
+    instrument_hooks
+    instrument-hooks/dist/core.c
+)
+
+# Suppress warnings for the instrument_hooks library
+target_compile_options(
+    instrument_hooks
+    PRIVATE
+    -Wno-maybe-uninitialized
+    -Wno-unused-variable
+    -Wno-unused-parameter
+    -Wno-unused-but-set-variable
+    -Wno-type-limits
+)
+
+# Add the main library
 add_library(
     codspeed
     src/codspeed.cpp
     src/walltime.cpp
     src/uri.cpp
     src/workspace.cpp
-    instrument-hooks/dist/core.c
 )
 
-# Suppress warnings only for instrument-hooks/dist/core.c
-set_source_files_properties(
-    instrument-hooks/dist/core.c
-    PROPERTIES COMPILE_FLAGS "-Wno-unused-variable -Wno-unused-parameter"
-)
+# Link instrument_hooks to codspeed
+target_link_libraries(codspeed PRIVATE instrument_hooks)
 
 # Version
 add_compile_definitions(CODSPEED_VERSION="${CODSPEED_VERSION}")
@@ -125,7 +138,7 @@ install(
 )
 
 install(
-    TARGETS codspeed
+    TARGETS codspeed instrument_hooks
     EXPORT codspeed-targets
     LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
     ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}

google_benchmark/src/CMakeLists.txt

@@ -92,7 +92,7 @@ set(project_config "${generated_dir}/${PROJECT_NAME}Config.cmake")
 set(pkg_config "${generated_dir}/${PROJECT_NAME}.pc")
 set(pkg_config_main "${generated_dir}/${PROJECT_NAME}_main.pc")
 # TODO: Find a way to not expose codspeed headers to downstream users
-set(targets_to_export benchmark benchmark_main codspeed)
+set(targets_to_export benchmark benchmark_main codspeed instrument_hooks)
 set(targets_export_name "${PROJECT_NAME}Targets")
 
 set(namespace "${PROJECT_NAME}::")