fix: sync compiler flags with instrument-hooks

Author: not-matthias

core/BUILD

@@ -24,13 +24,14 @@ cc_library(
             "/wd4146",  # unary minus operator applied to unsigned type
         ],
         "//conditions:default": [
-            "-Wno-maybe-uninitialized",
-            "-Wno-unused-variable",
-            "-Wno-unused-parameter",
+            # IMPORTANT: Keep in sync with instrument-hooks/ci.yml (COMMON_CFLAGS)
+            "-Wall",
+            "-Werror",
+            "-Wno-format-security",
             "-Wno-unused-but-set-variable",
+            "-Wno-unused-const-variable",
             "-Wno-type-limits",
-            "-Wno-format",
-            "-Wno-format-security",
+            "-Wno-uninitialized",
         ],
     }),
     visibility = ["//visibility:public"],

core/CMakeLists.txt

@@ -40,16 +40,17 @@ target_include_directories(
 
 # Suppress warnings for the instrument_hooks library
 if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+    # IMPORTANT: Keep in sync with instrument-hooks/ci.yml (COMMON_CFLAGS)
     target_compile_options(
         instrument_hooks
         PRIVATE
-        -Wno-maybe-uninitialized
-        -Wno-unused-variable
-        -Wno-unused-parameter
+        -Wall
+        -Werror
+        -Wno-format-security
         -Wno-unused-but-set-variable
+        -Wno-unused-const-variable
         -Wno-type-limits
-        -Wno-format
-        -Wno-format-security
+        -Wno-uninitialized
     )
 elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     target_compile_options(