fix: call stop_benchmark in google benchmark

not-matthias · not-matthias · commit bac36bade5c6 · 2025-07-02T18:24:30.000+02:00
diff --git a/core/src/codspeed.cpp b/core/src/codspeed.cpp
@@ -85,7 +85,6 @@ void CodSpeed::start_benchmark(const std::string &name) {
 }
 
 void CodSpeed::end_benchmark() {
-  measurement_stop(current_benchmark);
   benchmarked.push_back(current_benchmark);
   std::string action_str = is_instrumented ? "Measured" : "Checked";
   std::string group_str =
diff --git a/google_benchmark/include/benchmark/benchmark.h b/google_benchmark/include/benchmark/benchmark.h
@@ -1066,6 +1066,7 @@ struct State::StateIterator {
     if (BENCHMARK_BUILTIN_EXPECT(cached_ != 0, true)) return true;
 #ifdef CODSPEED_INSTRUMENTATION
     if (parent_->codspeed_ != NULL) {
+      measurement_stop();
       parent_->codspeed_->end_benchmark();
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,6 @@ void CodSpeed::start_benchmark(const std::string &name) {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`void CodSpeed::end_benchmark() {`
`88`		`- measurement_stop(current_benchmark);`
`89`	`88`	`benchmarked.push_back(current_benchmark);`
`90`	`89`	`std::string action_str = is_instrumented ? "Measured" : "Checked";`
`91`	`90`	`std::string group_str =`
Original file line number	Diff line number	Diff line change
`@@ -1066,6 +1066,7 @@ struct State::StateIterator {`
`1066`	`1066`	`if (BENCHMARK_BUILTIN_EXPECT(cached_ != 0, true)) return true;`
`1067`	`1067`	`#ifdef CODSPEED_INSTRUMENTATION`
`1068`	`1068`	`if (parent_->codspeed_ != NULL) {`
	`1069`	`+ measurement_stop();`
`1069`	`1070`	`parent_->codspeed_->end_benchmark();`
`1070`	`1071`	`}`
`1071`	`1072`	`#endif`