fix: sync compiler flags with instrument-hooks; add strict mode

Author: not-matthias

core/BUILD

@@ -8,30 +8,60 @@ config_setting(
     constraint_values = ["@platforms//os:windows"],
 )
 
+# Strict warnings mode
+string_flag(
+    name = "strict_warnings",
+    build_setting_default = "off",
+    values = [
+        "off",
+        "on",
+    ],
+)
+
+config_setting(
+    name = "strict_warnings_enabled",
+    flag_values = {":strict_warnings": "on"},
+)
+
+config_setting(
+    name = "windows_strict_warnings",
+    constraint_values = ["@platforms//os:windows"],
+    flag_values = {":strict_warnings": "on"},
+)
+
+# IMPORTANT: Keep in sync with instrument-hooks/ci.yml (COMMON_CFLAGS)
+instrument_hooks_cflags = [
+    "-Wno-format-security",
+    "-Wno-unused-but-set-variable",
+    "-Wno-unused-const-variable",
+    "-Wno-type-limits",
+    "-Wno-uninitialized",
+    # When cross-compiling:
+    "-Wno-constant-conversion",
+    "-Wno-incompatible-pointer-types",
+    "-Wno-unused-function",
+]
+
+instrument_hooks_cflags_windows = [
+    "/wd4101",  # unreferenced local variable (equivalent to -Wno-unused-variable)
+    "/wd4189",  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
+    "/wd4100",  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
+    "/wd4245",  # signed/unsigned mismatch
+    "/wd4132",  # const object should be initialized
+    "/wd4146",  # unary minus operator applied to unsigned type
+]
+
 # Instrument-hooks library with warning suppressions
 cc_library(
     name = "instrument_hooks",
     srcs = ["instrument-hooks/dist/core.c"],
     hdrs = glob(["instrument-hooks/includes/*.h"]),
     includes = ["instrument-hooks/includes"],
     copts = select({
-        ":windows": [
-            "/wd4101",  # unreferenced local variable (equivalent to -Wno-unused-variable)
-            "/wd4189",  # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
-            "/wd4100",  # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
-            "/wd4245",  # signed/unsigned mismatch
-            "/wd4132",  # const object should be initialized
-            "/wd4146",  # unary minus operator applied to unsigned type
-        ],
-        "//conditions:default": [
-            "-Wno-maybe-uninitialized",
-            "-Wno-unused-variable",
-            "-Wno-unused-parameter",
-            "-Wno-unused-but-set-variable",
-            "-Wno-type-limits",
-            "-Wno-format",
-            "-Wno-format-security",
-        ],
+        ":windows_strict_warnings": ["/W4","/WX"] + instrument_hooks_cflags_windows,
+        ":windows": instrument_hooks_cflags_windows,
+        ":strict_warnings_enabled": ["-Wall", "-Werror"] + instrument_hooks_cflags,
+        "//conditions:default": instrument_hooks_cflags,
     }),
     visibility = ["//visibility:public"],
 )

core/CMakeLists.txt

@@ -38,18 +38,32 @@ target_include_directories(
     $<INSTALL_INTERFACE:includes>
 )
 
+# Option to enable strict warnings (for CI builds)
+option(CODSPEED_STRICT_WARNINGS "Enable strict warnings" OFF)
+
 # Suppress warnings for the instrument_hooks library
 if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+    # IMPORTANT: Keep in sync with instrument-hooks/ci.yml (COMMON_CFLAGS)
+    set(INSTRUMENT_HOOKS_CFLAGS
+        -Wno-format-security
+        -Wno-unused-but-set-variable
+        -Wno-unused-const-variable
+        -Wno-type-limits
+        -Wno-uninitialized
+        # When cross-compiling:
+        -Wno-constant-conversion
+        -Wno-incompatible-pointer-types
+        -Wno-unused-function
+    )
+
+    if(CODSPEED_STRICT_WARNINGS)
+        list(PREPEND INSTRUMENT_HOOKS_CFLAGS -Wall -Werror)
+    endif()
+
     target_compile_options(
         instrument_hooks
         PRIVATE
-        -Wno-maybe-uninitialized
-        -Wno-unused-variable
-        -Wno-unused-parameter
-        -Wno-unused-but-set-variable
-        -Wno-type-limits
-        -Wno-format
-        -Wno-format-security
+        ${INSTRUMENT_HOOKS_CFLAGS}
     )
 elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
     target_compile_options(