Skip to content

Commit da6c95f

Browse files
committed
fix: compiler warnings
1 parent da25a57 commit da6c95f

File tree

2 files changed

+31
-10
lines changed

2 files changed

+31
-10
lines changed

core/BUILD

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,18 @@ cc_library(
1414
srcs = ["instrument-hooks/dist/core.c"],
1515
hdrs = glob(["instrument-hooks/includes/*.h"]),
1616
includes = ["instrument-hooks/includes"],
17-
copts = ["-Wno-unused-variable", "-Wno-unused-parameter", "-Wno-unused-but-set-variable"],
17+
copts = select({
18+
":windows": [
19+
"/wd4101", # unreferenced local variable (equivalent to -Wno-unused-variable)
20+
"/wd4189", # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
21+
"/wd4100", # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
22+
],
23+
"//conditions:default": [
24+
"-Wno-unused-variable",
25+
"-Wno-unused-parameter",
26+
"-Wno-unused-but-set-variable",
27+
],
28+
}),
1829
)
1930

2031
# Define the codspeed library

core/CMakeLists.txt

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,25 @@ add_library(
1919
)
2020

2121
# Suppress warnings for the instrument_hooks library
22-
target_compile_options(
23-
instrument_hooks
24-
PRIVATE
25-
-Wno-maybe-uninitialized
26-
-Wno-unused-variable
27-
-Wno-unused-parameter
28-
-Wno-unused-but-set-variable
29-
-Wno-type-limits
30-
)
22+
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
23+
target_compile_options(
24+
instrument_hooks
25+
PRIVATE
26+
-Wno-maybe-uninitialized
27+
-Wno-unused-variable
28+
-Wno-unused-parameter
29+
-Wno-unused-but-set-variable
30+
-Wno-type-limits
31+
)
32+
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
33+
target_compile_options(
34+
instrument_hooks
35+
PRIVATE
36+
/wd4101 # unreferenced local variable (equivalent to -Wno-unused-variable)
37+
/wd4189 # local variable is initialized but not referenced (equivalent to -Wno-unused-but-set-variable)
38+
/wd4100 # unreferenced formal parameter (equivalent to -Wno-unused-parameter)
39+
)
40+
endif()
3141

3242
# Add the main library
3343
add_library(

0 commit comments

Comments
 (0)