test ci

Author: GuillaumeLagrange

core/include/codspeed.h

@@ -34,7 +34,7 @@ class CodSpeed {
 struct RawWalltimeBenchmark {
   std::string name;
   std::string uri;
-  int64_t iter_per_round;
+  uint64_t iter_per_round;
   double mean_ns;
   double median_ns;
   double stdev_ns;

core/src/walltime.cpp

@@ -32,7 +32,7 @@ struct BenchmarkStats {
   double total_time;
   uint64_t iqr_outlier_rounds;
   uint64_t stdev_outlier_rounds;
-  int64_t iter_per_round;
+  uint64_t iter_per_round;
   uint64_t warmup_iters;
 };
 

core/src/workspace.cpp

@@ -9,6 +9,8 @@ namespace codspeed {
 
 std::string safe_getenv(const char* var_name) {
 #ifdef _WIN32
+  // On Windows, use _dupenv_s instead of std::getenv for thread safety
+  // and to avoid issues with buffer ownership
   char* value;
   size_t len;
   errno_t err = _dupenv_s(&value, &len, var_name);

google_benchmark/include/benchmark/benchmark.h

@@ -185,10 +185,10 @@ BENCHMARK(BM_test)->Unit(benchmark::kMillisecond);
 
 #ifdef CODSPEED_ENABLED
 #include <codspeed.h>
-#include <measurement.hpp>
 
 #include <filesystem>
-#endif // CODSPEED_ENABLED
+#include <measurement.hpp>
+#endif  // CODSPEED_ENABLED
 
 #if defined(_MSC_VER)
 #include <intrin.h>  // for _ReadWriteBarrier
@@ -947,7 +947,7 @@ class BENCHMARK_EXPORT BENCHMARK_INTERNAL_CACHELINE_ALIGNED State {
  public:
   const IterationCount max_iterations;
 #ifdef CODSPEED_INSTRUMENTATION
-  codspeed::CodSpeed *codspeed_;
+  codspeed::CodSpeed* codspeed_;
 #endif
 
  private:
@@ -970,11 +970,11 @@ class BENCHMARK_EXPORT BENCHMARK_INTERNAL_CACHELINE_ALIGNED State {
         internal::ThreadTimer* timer, internal::ThreadManager* manager,
         internal::PerfCountersMeasurement* perf_counters_measurement,
         ProfilerManager* profiler_manager
-  #ifdef CODSPEED_INSTRUMENTATION
+#ifdef CODSPEED_INSTRUMENTATION
         ,
-        codspeed::CodSpeed *codspeed = NULL
-  #endif
-        );
+        codspeed::CodSpeed* codspeed = NULL
+#endif
+  );
 
   void StartKeepRunning();
   // Implementation of KeepRunning() and KeepRunningBatch().
@@ -1460,26 +1460,23 @@ class Fixture : public internal::Benchmark {
   BaseClass##_##Method##_Benchmark
 
 #ifdef _MSC_VER
-#define BENCHMARK_PRIVATE_DECLARE(n)                                           \
-  /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */                           \
-  static ::benchmark::internal::Benchmark const* const BENCHMARK_PRIVATE_NAME( \
-      n)
+#define BENCHMARK_PRIVATE_DECLARE(n)                 \
+  /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */ \
+  static ::benchmark::internal::Benchmark const* const BENCHMARK_PRIVATE_NAME(n)
 #else
-#define BENCHMARK_PRIVATE_DECLARE(n)                                           \
-  /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */                           \
-  static ::benchmark::internal::Benchmark const* const BENCHMARK_PRIVATE_NAME( \
-      n) [[maybe_unused]]
+#define BENCHMARK_PRIVATE_DECLARE(n)                 \
+  /* NOLINTNEXTLINE(misc-use-anonymous-namespace) */ \
+  static ::benchmark::internal::Benchmark const* const BENCHMARK_PRIVATE_NAME(n)
 #endif
 
 #ifdef CODSPEED_ENABLED
-#define CUR_FILE \
-  codspeed::get_path_relative_to_workspace(__FILE__) + "::"
+#define CUR_FILE codspeed::get_path_relative_to_workspace(__FILE__) + "::"
 #ifdef _MSC_VER
-#define NAMESPACE std::string("")
-#else
+// TODO: __PRETTY_FUNCTION__ is not available in MSVC and we dont support
+#define __PRETTY_FUNCTION__ "unsupported"
+#endif
 #define NAMESPACE \
   (([]() { return codspeed::extract_lambda_namespace(__PRETTY_FUNCTION__); })())
-#endif
 #define STATIC_NAMESPACE_STRING(name) static std::string name = NAMESPACE;
 
 #define FILE_AND_NAMESPACE CUR_FILE + NAMESPACE
@@ -1618,12 +1615,12 @@ class Fixture : public internal::Benchmark {
 #ifdef CODSPEED_ENABLED
 
 #define BENCHMARK_PRIVATE_DECLARE_F(BaseClass, Method)        \
-    STATIC_NAMESPACE_STRING(ns_##BaseClass##_##Method);         \
+  STATIC_NAMESPACE_STRING(ns_##BaseClass##_##Method);         \
   class BaseClass##_##Method##_Benchmark : public BaseClass { \
    public:                                                    \
     BaseClass##_##Method##_Benchmark() {                      \
       this->SetName(CUR_FILE + ns_##BaseClass##_##Method +    \
-                    #Method "[" #BaseClass "]");                  \
+                    #Method "[" #BaseClass "]");              \
     }                                                         \
                                                               \
    protected:                                                 \
@@ -1669,7 +1666,7 @@ class Fixture : public internal::Benchmark {
     void BenchmarkCase(::benchmark::State&) override;                      \
   };
 
-#else // CODSPEED_ENABLED undefined:
+#else  // CODSPEED_ENABLED undefined:
 
 #define BENCHMARK_PRIVATE_DECLARE_F(BaseClass, Method)        \
   class BaseClass##_##Method##_Benchmark : public BaseClass { \