feat: add perf v2 support #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Instrumentation Performance ReportMerging #19 will degrade performances by 32.31%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Pull Request Overview
Add wall-time instrumentation support for CodSpeed Perf v2 in the Google Benchmark integration and extend examples and CI to exercise and report the new mode.
- Track wall-time intervals across PauseTiming/ResumeTiming via measurement markers.
- Add example benchmarks (pause timing and multithread) and update CI to use the action mode input.
- Extend measurement helpers with timestamp/marker APIs and assertions.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| google_benchmark/src/benchmark.cc | Integrates wall-time markers on PauseTiming/ResumeTiming and initializes resume_timestamp_. |
| google_benchmark/include/benchmark/benchmark.h | Declares resume_timestamp_ and minor formatting in StateIterator; supports new instrumentation state. |
| core/include/measurement.hpp | Adds current timestamp/marker APIs and helper to record benchmark segments with asserts. |
| examples/google_benchmark_cmake/pause_timing_bench.hpp | Adds pause/resume timing example showcasing excluded work. |
| examples/google_benchmark_cmake/multithread_bench.hpp | Adds multithreaded example (spawn/join worker). |
| examples/google_benchmark_cmake/helper.hpp | Adds helper functions to simulate expensive work. |
| examples/google_benchmark_bazel/* | Reuse example headers from CMake examples. |
| .github/workflows/ci.yml | Switches to CodSpeed action mode input and simplifies env configuration. |
| core/instrument-hooks | Submodule bump to pick up new instrumentation hooks. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
not-matthias
force-pushed
the
cod-1379-codspeed-cpp-add-perf-v2-support
branch
2 times, most recently
from
be4f1b0 to
6c5a279
Compare
CodSpeed WallTime Performance ReportMerging #19 will not alter performanceComparing Summary
Benchmarks breakdown
Footnotes |
not-matthias
force-pushed
the
cod-1379-codspeed-cpp-add-perf-v2-support
branch
from
c37d4b9 to
184c4ea
Compare
not-matthias
force-pushed
the
cod-1379-codspeed-cpp-add-perf-v2-support
branch
2 times, most recently
from
c656915 to
b7430ca
Compare
not-matthias
changed the title
not-matthias
force-pushed
the
cod-1379-codspeed-cpp-add-perf-v2-support
branch
3 times, most recently
from
6a91319 to
c2bb143
Compare
not-matthias
force-pushed
the
cod-1379-codspeed-cpp-add-perf-v2-support
branch
2 times, most recently
from
4ae97f8 to
6f15825
Compare
not-matthias
force-pushed
the
cod-1379-codspeed-cpp-add-perf-v2-support
branch
from
6f15825 to
7c2430e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on CodSpeedHQ/instrument-hooks#9