-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add support for setting a custom benchmark name #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for setting a custom benchmark name #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to allow setting custom benchmark names in Google Benchmark while preserving file path and namespace prefixes when CODSPEED_ENABLED is defined. The implementation handles parameter preservation in the benchmark naming format.
Key changes:
- Modified
SetName()to intelligently preserve file/namespace prefixes and parameters - Added comprehensive test cases demonstrating custom naming with various scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| google_benchmark/src/benchmark_register.cc | Updated SetName() method to preserve file path, namespace prefix, and parameters when CODSPEED_ENABLED |
| examples/google_benchmark_cmake/main.cpp | Added test cases for custom benchmark naming including nested namespaces, captured benchmarks, and parameterized benchmarks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1383fa0 to
3c5fc6b
Compare
CodSpeed Performance ReportMerging #31 will degrade performances by 32.21%Comparing Summary
Benchmarks breakdown
|
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
olgtm
0b8e25e to
a34fdd1
Compare
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Guillaume Lagrange <[email protected]>
a34fdd1 to
cf778ec
Compare
No description provided.