wip: add debug logs; remove start/stop timer in fast path of b.Loop()

Author: not-matthias

testing/testing/benchmark.go

@@ -182,11 +182,15 @@ func (b *B) StopTimer() {
 		// If we hit B.Loop with the timer stopped, fail.
 		// b.loop.i |= loopPoisonTimer
 
-
 		// Accumulate timestamps for batch submission instead of immediate hook call
 		b.codspeed.accumulatedStartTimestamps = append(b.codspeed.accumulatedStartTimestamps, b.codspeed.startTimestamp)
 		b.codspeed.accumulatedEndTimestamps = append(b.codspeed.accumulatedEndTimestamps, endTimestamp)
 
+		// Debug log every 10000 accumulated timestamps to detect potential memory issues
+		if len(b.codspeed.accumulatedStartTimestamps)%10000 == 0 && len(b.codspeed.accumulatedStartTimestamps) > 0 {
+			fmt.Printf("DEBUG: Accumulated %d timestamp pairs for benchmark %s\n", len(b.codspeed.accumulatedStartTimestamps), b.name)
+		}
+
 		// For b.N loops: This will be called in runN which sets b.N to the number of iterations.
 		// For b.Loop() loops: loopSlowPath sets b.N to 0 to prevent b.N loops within b.Loop. However, since
 		// we're starting/stopping the timer for each iteration in the b.Loop() loop, we can use 1 as
@@ -225,7 +229,11 @@ func (b *B) ResetTimer() {
 }
 
 func (b *B) submitAccumulatedTimestamps() {
-	for i := 0; i < len(b.codspeed.accumulatedStartTimestamps); i++ {
+	numTimestamps := len(b.codspeed.accumulatedStartTimestamps)
+	if numTimestamps > 0 {
+		fmt.Printf("DEBUG: Submitting %d accumulated timestamp pairs for benchmark %s\n", numTimestamps, b.name)
+	}
+	for i := 0; i < numTimestamps; i++ {
 		b.codspeed.instrument_hooks.AddBenchmarkTimestamps(
 			b.codspeed.accumulatedStartTimestamps[i],
 			b.codspeed.accumulatedEndTimestamps[i],
@@ -598,7 +606,7 @@ func (b *B) loopSlowPath() bool {
 // whereas b.N-based benchmarks must run the benchmark function (and any
 // associated setup and cleanup) several times.
 func (b *B) Loop() bool {
-	b.StopTimer()
+	// b.StopTimer()
 	// This is written such that the fast path is as fast as possible and can be
 	// inlined.
 	//
@@ -613,7 +621,7 @@ func (b *B) Loop() bool {
 	//   path can do consistency checks and fail.
 	if b.loop.i < b.loop.n {
 		b.loop.i++
-		b.StartTimer()
+		// b.StartTimer()
 		return true
 	}
 	return b.loopSlowPath()