feat: add instrumentation to extract round times

Author: not-matthias

testing/testing/benchmark.go

@@ -6,15 +6,11 @@ package testing
 
 import (
 	"context"
-	"crypto/rand"
-	"encoding/hex"
-	"encoding/json"
 	"flag"
 	"fmt"
 	"io"
 	"math"
 	"os"
-	"path/filepath"
 	"runtime"
 	"slices"
 	"strconv"
@@ -469,8 +465,6 @@ func (b *B) loopSlowPath() bool {
 		if b.loop.n < uint64(b.benchTime.n) {
 			b.loop.n = uint64(b.benchTime.n)
 			b.loop.i++
-			b.ResetTimer()
-			b.StartTimer()
 			return true
 		}
 		b.StopTimer()
@@ -793,79 +787,6 @@ func (s *benchState) processBench(b *B) {
 				continue
 			}
 			results := r.String()
-
-			// ############################################################################################
-			// START CODSPEED
-			type RawResults struct {
-				BenchmarkName          string          `json:"benchmark_name"`
-				Pid                    int             `json:"pid"`
-				CodspeedTimePerRoundNs []time.Duration `json:"codspeed_time_per_round_ns"`
-				CodspeedItersPerRound  []int64         `json:"codspeed_iters_per_round"`
-			}
-
-			// Build custom bench name with :: separator
-			var nameParts []string
-			current := &b.common
-			for current.parent != nil {
-				// Extract the sub-benchmark part by removing parent prefix
-				parentName := current.parent.name
-				if strings.HasPrefix(current.name, parentName+"/") {
-					subName := strings.TrimPrefix(current.name, parentName+"/")
-					nameParts = append([]string{subName}, nameParts...)
-				} else {
-					nameParts = append([]string{current.name}, nameParts...)
-				}
-
-				if current.parent.name == "Main" {
-					break
-				}
-				current = current.parent
-			}
-			customBenchName := strings.Join(nameParts, "::")
-
-			rawResults := RawResults{
-				BenchmarkName:          customBenchName,
-				Pid:                    os.Getpid(),
-				CodspeedTimePerRoundNs: r.CodspeedTimePerRoundNs,
-				CodspeedItersPerRound:  r.CodspeedItersPerRound,
-			}
-
-			codspeedProfileFolder := os.Getenv("CODSPEED_PROFILE_FOLDER")
-			if codspeedProfileFolder == "" {
-				panic("CODSPEED_PROFILE_FOLDER environment variable is not set")
-			}
-			if err := os.MkdirAll(filepath.Join(codspeedProfileFolder, "raw_results"), 0755); err != nil {
-				fmt.Fprintf(os.Stderr, "failed to create raw results directory: %v\n", err)
-				continue
-			}
-			// Generate random filename to avoid any overwrites
-			randomBytes := make([]byte, 16)
-			if _, err := rand.Read(randomBytes); err != nil {
-				fmt.Fprintf(os.Stderr, "failed to generate random filename: %v\n", err)
-				continue
-			}
-			rawResultsFile := filepath.Join(codspeedProfileFolder, "raw_results", fmt.Sprintf("%s.json", hex.EncodeToString(randomBytes)))
-			file, err := os.Create(rawResultsFile)
-			if err != nil {
-				fmt.Fprintf(os.Stderr, "failed to create raw results file: %v\n", err)
-				continue
-			}
-			output, err := json.MarshalIndent(rawResults, "", "  ")
-			if err != nil {
-				fmt.Fprintf(os.Stderr, "failed to marshal raw results: %v\n", err)
-				file.Close()
-				continue
-			}
-			// FIXME: Don't overwrite the file if it already exists
-			if _, err := file.Write(output); err != nil {
-				fmt.Fprintf(os.Stderr, "failed to write raw results: %v\n", err)
-				file.Close()
-				continue
-			}
-			defer file.Close()
-			// END CODSPEED
-			// ############################################################################################
-
 			if b.chatty != nil {
 				fmt.Fprintf(b.w, "%-*s\t", s.maxLen, benchName)
 			}