fix: properly name native functions

Author: art049

packages/benchmark.js/src/index.ts

@@ -22,9 +22,9 @@ function withCodSpeedBenchmark(bench: Benchmark): Benchmark {
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   bench.run = function (options?: Benchmark.Options): Benchmark {
     const uri = callingFile + "::" + (bench.name ?? "unknown");
-    measurement.startMeasurement();
+    measurement.startInstrumentation();
     (bench.fn as CallableFunction)();
-    measurement.stopMeasurement(uri);
+    measurement.stopInstrumentation(uri);
     return bench;
   };
   return bench;
@@ -46,9 +46,9 @@ function withCodSpeedSuite(suite: Benchmark.Suite): Benchmark.Suite {
     for (let i = 0; i < benches.length; i++) {
       const bench = benches[i];
       const uri = baseUri + "::" + (bench.name ?? `unknown_${i}`);
-      measurement.startMeasurement();
+      measurement.startInstrumentation();
       (bench.fn as CallableFunction)();
-      measurement.stopMeasurement(uri);
+      measurement.stopInstrumentation(uri);
     }
     return suite;
   };

packages/benchmark.js/tests/unit.test.ts

@@ -26,8 +26,8 @@ describe("Benchmark", () => {
       maxTime: -Infinity,
     });
     expect(onComplete).toHaveBeenCalled();
-    expect(mockCore.startMeasurement).not.toHaveBeenCalled();
-    expect(mockCore.stopMeasurement).not.toHaveBeenCalled();
+    expect(mockCore.startInstrumentation).not.toHaveBeenCalled();
+    expect(mockCore.stopInstrumentation).not.toHaveBeenCalled();
   });
   it("check core methods are called", () => {
     mockCore.isInstrumented.mockReturnValue(true);
@@ -37,8 +37,8 @@ describe("Benchmark", () => {
         /o/.test("Hello World!");
       })
     ).run();
-    expect(mockCore.startMeasurement).toHaveBeenCalled();
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.startInstrumentation).toHaveBeenCalled();
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/benchmark.js/tests/unit.test.ts::RegExpSingle"
     );
   });
@@ -55,8 +55,8 @@ describe("Benchmark.Suite", () => {
     suite.on("complete", onComplete);
     suite.run({ maxTime: 0.1, initCount: 1 });
     expect(onComplete).toHaveBeenCalled();
-    expect(mockCore.startMeasurement).not.toHaveBeenCalled();
-    expect(mockCore.stopMeasurement).not.toHaveBeenCalled();
+    expect(mockCore.startInstrumentation).not.toHaveBeenCalled();
+    expect(mockCore.stopInstrumentation).not.toHaveBeenCalled();
   });
   it("check core methods are called", () => {
     mockCore.isInstrumented.mockReturnValue(true);
@@ -65,8 +65,8 @@ describe("Benchmark.Suite", () => {
         /o/.test("Hello World!");
       })
       .run();
-    expect(mockCore.startMeasurement).toHaveBeenCalled();
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.startInstrumentation).toHaveBeenCalled();
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/benchmark.js/tests/unit.test.ts::RegExp"
     );
   });
@@ -80,10 +80,10 @@ describe("Benchmark.Suite", () => {
         /o/.test("Hello World!");
       })
       .run();
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/benchmark.js/tests/unit.test.ts::thesuite::RegExp"
     );
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/benchmark.js/tests/unit.test.ts::thesuite::unknown_1"
     );
   });

packages/core/src/index.ts

@@ -3,8 +3,8 @@ import path from "path";
 /* eslint-disable @typescript-eslint/no-empty-function */
 export interface Measurement {
   isInstrumented(): boolean;
-  startMeasurement(): void;
-  stopMeasurement(at: string): void;
+  startInstrumentation(): void;
+  stopInstrumentation(at: string): void;
   isBound: boolean;
 }
 
@@ -20,9 +20,9 @@ try {
   console.warn("@codspeed/core binding not available on this architecture");
   m = {
     isInstrumented: () => false,
-    startMeasurement: () => {},
+    startInstrumentation: () => {},
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    stopMeasurement: (at) => {},
+    stopInstrumentation: (at) => {},
     isBound: false,
   };
 }

packages/tinybench/src/index.ts

@@ -12,9 +12,9 @@ export function withCodSpeed(bench: Bench): Bench {
   bench.run = async () => {
     for (const task of bench.tasks) {
       const uri = callingFile + "::" + task.name;
-      measurement.startMeasurement();
+      measurement.startInstrumentation();
       await task.fn();
-      measurement.stopMeasurement(uri);
+      measurement.stopInstrumentation(uri);
     }
     return bench.tasks;
   };

packages/tinybench/tests/unit.test.ts

@@ -23,8 +23,8 @@ describe("Benchmark.Suite", () => {
     await bench.run();
 
     expect(onComplete).toHaveBeenCalled();
-    expect(mockCore.startMeasurement).not.toHaveBeenCalled();
-    expect(mockCore.stopMeasurement).not.toHaveBeenCalled();
+    expect(mockCore.startInstrumentation).not.toHaveBeenCalled();
+    expect(mockCore.stopInstrumentation).not.toHaveBeenCalled();
   });
   it("check core methods are called", async () => {
     mockCore.isInstrumented.mockReturnValue(true);
@@ -33,8 +33,8 @@ describe("Benchmark.Suite", () => {
         /o/.test("Hello World!");
       })
       .run();
-    expect(mockCore.startMeasurement).toHaveBeenCalled();
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.startInstrumentation).toHaveBeenCalled();
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/tinybench/tests/unit.test.ts::RegExp"
     );
   });
@@ -48,10 +48,10 @@ describe("Benchmark.Suite", () => {
         /o/.test("Hello World!");
       })
       .run();
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/tinybench/tests/unit.test.ts::RegExp"
     );
-    expect(mockCore.stopMeasurement).toHaveBeenCalledWith(
+    expect(mockCore.stopInstrumentation).toHaveBeenCalledWith(
       "packages/tinybench/tests/unit.test.ts::RegExp2"
     );
   });