chore: test ci

Author: GuillaumeLagrange

packages/core/src/index.ts

@@ -10,24 +10,24 @@ export const isBound = native_core.isBound;
 
 export const mongoMeasurement = new MongoMeasurement();
 
-export enum MeasurementMode {
-  Instrumentation = "instrumentation",
-  WallTime = "walltime",
-}
+type CodSpeedRunnerMode = "disabled" | "instrumented" | "walltime";
 
-export function getMeasurementMode(): MeasurementMode {
+export function getCodspeedRunnerMode(): CodSpeedRunnerMode {
   const isCodSpeedEnabled = process.env.CODSPEED_ENV !== undefined;
-  if (isCodSpeedEnabled) {
-    // If CODSPEED_ENV is set, check CODSPEED_RUNNER_MODE
-    if (process.env.CODSPEED_RUNNER_MODE === "walltime") {
-      return MeasurementMode.WallTime;
-    } else {
-      return MeasurementMode.Instrumentation;
-    }
+  if (!isCodSpeedEnabled) {
+    return "disabled";
+  }
+
+  // If CODSPEED_ENV is set, check CODSPEED_RUNNER_MODE
+  const codspeedRunnerMode = process.env.CODSPEED_RUNNER_MODE;
+  if (codspeedRunnerMode === "instrumentation") {
+    return "instrumented";
+  } else if (codspeedRunnerMode === "walltime") {
+    return "walltime";
   }
 
-  // Default to walltime mode when CODSPEED_ENV is not set
-  return MeasurementMode.WallTime;
+  console.warn("Unknown codspeed runner mode, defaulting to disabled");
+  return "disabled";
 }
 
 export const setupCore = () => {

packages/vitest-plugin/src/index.ts

@@ -1,4 +1,5 @@
 import {
+  getCodspeedRunnerMode,
   getV8Flags,
   Measurement,
   mongoMeasurement,
@@ -20,21 +21,12 @@ function getCodSpeedFileFromName(name: string) {
 }
 
 function getRunnerFile(): string | undefined {
-  // If CODSPEED_ENV is not set, use default vitest behavior
-  if (!process.env.CODSPEED_ENV) {
-    // TODO: Change this
-    // return undefined;
-    return getCodSpeedFileFromName("walltime");
+  const codspeedRunnerMode = getCodspeedRunnerMode();
+  if (codspeedRunnerMode === "disabled") {
+    return undefined;
   }
 
-  const runnerMode = process.env.CODSPEED_RUNNER_MODE;
-
-  if (runnerMode === "instrumentation") {
-    return getCodSpeedFileFromName("runner");
-  } else {
-    // Default to walltime mode (includes "walltime" mode and unrecognized modes)
-    return getCodSpeedFileFromName("walltime");
-  }
+  return getCodSpeedFileFromName(codspeedRunnerMode);
 }
 
 export default function codspeedPlugin(): Plugin {
@@ -44,7 +36,10 @@ export default function codspeedPlugin(): Plugin {
       if (mode !== "benchmark") {
         return false;
       }
-      if (!Measurement.isInstrumented()) {
+      if (
+        getCodspeedRunnerMode() == "instrumented" &&
+        !Measurement.isInstrumented()
+      ) {
         console.warn("[CodSpeed] bench detected but no instrumentation found");
       }
       return true;

packages/vitest-plugin/src/instrumented.ts

@@ -105,3 +105,5 @@ export class InstrumentedRunner extends NodeBenchmarkRunner {
     teardownCore();
   }
 }
+
+export default InstrumentedRunner;

packages/vitest-plugin/src/walltime.ts

@@ -98,6 +98,11 @@ export class WalltimeRunner extends NodeBenchmarkRunner {
         result as VitestTaskResult
       );
 
+      if (stats === null) {
+        console.log(`    ✔ No walltime data to collect for ${uri}`);
+        return null;
+      }
+
       const coreBenchmark: Benchmark = {
         name: task.name,
         uri,
@@ -121,7 +126,7 @@ export class WalltimeRunner extends NodeBenchmarkRunner {
 
   private convertVitestResultToBenchmarkStats(
     result: VitestTaskResult
-  ): BenchmarkStats {
+  ): BenchmarkStats | null {
     const benchmark = result.benchmark;
 
     if (!benchmark) {
@@ -138,6 +143,12 @@ export class WalltimeRunner extends NodeBenchmarkRunner {
     const meanNs = ms_to_ns(mean);
     const stdevNs = ms_to_ns(sd);
 
+    if (sortedTimesNs.length == 0) {
+      // Sometimes the benchmarks can be completely optimized out and not even run, but its beforeEach and afterEach hooks are still executed, and the task is still considered a success.
+      // This is the case for the hooks.bench.ts example in this package
+      return null;
+    }
+
     const {
       q1_ns,
       q3_ns,