Skip to content

Commit e312a3b

Browse files
fix: stop relying on system valgrind to build
1 parent 759ec38 commit e312a3b

File tree

6 files changed

+3
-24
lines changed

6 files changed

+3
-24
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ jobs:
1414
with:
1515
fetch-depth: 0
1616
submodules: true
17-
- name: Install valgrind
18-
run: |
19-
sudo apt-get update
20-
sudo apt-get install -y valgrind
2117
- uses: pnpm/action-setup@v2
2218
- uses: actions/setup-node@v3
2319
with:
@@ -56,10 +52,6 @@ jobs:
5652
with:
5753
fetch-depth: 0
5854
submodules: true
59-
- name: Install valgrind
60-
run: |
61-
sudo apt-get update
62-
sudo apt-get install -y valgrind
6355
- uses: pnpm/action-setup@v2
6456
- uses: actions/setup-node@v3
6557
with:

.github/workflows/codspeed.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ jobs:
1515
with:
1616
fetch-depth: 0
1717
submodules: true
18-
- name: Install valgrind
19-
run: |
20-
sudo apt-get update
21-
sudo apt-get install -y valgrind
2218
- uses: pnpm/action-setup@v2
2319
- uses: actions/setup-node@v3
2420
with:
@@ -45,10 +41,6 @@ jobs:
4541
with:
4642
fetch-depth: 0
4743
submodules: true
48-
- name: Install valgrind
49-
run: |
50-
sudo apt-get update
51-
sudo apt-get install -y valgrind
5244
- uses: pnpm/action-setup@v2
5345
- uses: actions/setup-node@v3
5446
with:

.github/workflows/release.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ jobs:
2525
node-version-file: .nvmrc
2626
registry-url: "https://registry.npmjs.org"
2727
- run: pnpm install --frozen-lockfile --prefer-offline
28-
- name: Install valgrind
29-
run: |
30-
sudo apt-get update
31-
sudo apt-get install -y valgrind
32-
3328
- name: Build the libraries
3429
run: pnpm moon run :build
3530

flake.nix

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
setuptools
2424
]
2525
))
26-
valgrind # TODO: Remove this in favor of codspeed's valgrind
2726
];
2827

2928
in

packages/core/moon.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ tasks:
1212
command: prebuildify --napi --strip
1313
inputs:
1414
- "src/native_core/**/*.cc"
15+
- "src/native_core/**/*.c"
1516
- "src/native_core/**/*.h"
1617
- "binding.gyp"
1718
outputs:

packages/core/src/native_core/measurement/measurement.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
#include "callgrind.h"
12
#include "measurement.h"
2-
#include <valgrind/callgrind.h>
33

44
namespace codspeed_native {
55
namespace Measurement {
@@ -50,4 +50,4 @@ Napi::Object Initialize(Napi::Env env, Napi::Object exports) {
5050
}
5151

5252
} // namespace Measurement
53-
} // namespace codspeed_native
53+
} // namespace codspeed_native

0 commit comments

Comments
 (0)