--wip-- [skip ci]

Author: GuillaumeLagrange

crates/divan_compat/macros/Cargo.toml

@@ -26,7 +26,10 @@ proc-macro-crate = "3.2.0"
 proc-macro2 = "1"
 quote = { version = "1", default-features = false }
 # Versions prior to *.18 fail to parse empty attribute metadata.
-# syn = { version = "^2.0.18", default-features = false, features = ["full", "clone-impls", "parsing", "printing", "proc-macro"] }
-syn = { version = "^2.0.18", default-features = true, features = [
-  "extra-traits",
+syn = { version = "^2.0.18", default-features = false, features = [
+  "full",
+  "clone-impls",
+  "parsing",
+  "printing",
+  "proc-macro",
 ] }

crates/divan_compat/macros/src/lib.rs

@@ -31,26 +31,28 @@ pub fn bench_compat(attr: TokenStream, item: TokenStream) -> TokenStream {
 
     for arg in parsed_args.args {
         match &arg {
-            NameValue(MetaNameValue { path, .. }) if path.is_ident("crate") => {
-                return quote! {
-                    compile_error!("`crate` argument is not supported with codspeed_divan_compat");
+            NameValue(MetaNameValue { path, .. }) => {
+                match path.get_ident() {
+                    Some("crate") => {
+                        return quote! {
+                            compile_error!("`crate` argument is not supported with bench_compat");
+                        }
+                        .into();
+                    }
+                    Some("types") => {
+                        return quote! {
+                            compile_error!("`types` argument is not supported with bench_compat");
+                        }
+                        .into();
+                    }
+                    Some("min_time")
+                    | Some("max_time")
+                    | Some("sample_size")
+                    | Some("sample_count")
+                    | Some("skip_ext_time") => {
+                        // These arguments are ignored in instrumented mode
+                    }
                 }
-                .into();
-            }
-            NameValue(MetaNameValue { path, .. }) if path.is_ident("types") => {
-                return quote! {
-                    compile_error!("`type` argument is not yet supported with codspeed_divan_compat");
-                }
-                .into();
-            }
-            NameValue(MetaNameValue { path, .. })
-                if path.is_ident("min_time")
-                    || path.is_ident("max_time")
-                    || path.is_ident("sample_size")
-                    || path.is_ident("sample_count")
-                    || path.is_ident("skip_ext_time") =>
-            {
-                // These arguments are ignored in instrumented mode
             }
             _ => filtered_args.push(arg),
         }

crates/divan_compat/src/compat/mod.rs

@@ -1,6 +1,5 @@
 // Used by generated code from the macro `codspeed_divan_compat_macros::bench_compat`
 #[doc(hidden)]
-#[path = "private.rs"]
 pub mod __private {
     pub use super::{
         bench::{BenchArgs, BenchOptions},