Skip to content

Commit f676989

Browse files
committed
fixup! feat: expose a collection entrypoint usable within walltime integrations
1 parent 05c4545 commit f676989

File tree

3 files changed

+15
-17
lines changed

3 files changed

+15
-17
lines changed

Cargo.lock

Lines changed: 12 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/codspeed/src/walltime.rs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ pub struct RawWallTimeData {
1616
#[serde(flatten)]
1717
pub metadata: BenchmarkMetadata,
1818
pub iter_per_round: u32,
19-
pub min_time_ns: Option<u128>,
2019
pub max_time_ns: Option<u128>,
2120
pub times_ns: Vec<u128>,
2221
}
@@ -26,14 +25,12 @@ impl RawWallTimeData {
2625
name: String,
2726
uri: String,
2827
iter_per_round: u32,
29-
min_time_ns: Option<u128>,
3028
max_time_ns: Option<u128>,
3129
times_ns: Vec<u128>,
3230
) -> Self {
3331
RawWallTimeData {
3432
metadata: BenchmarkMetadata { name, uri },
3533
iter_per_round,
36-
min_time_ns,
3734
max_time_ns,
3835
times_ns,
3936
}
@@ -68,13 +65,6 @@ pub fn collect_raw_walltime_results(
6865
eprintln!("codspeed failed to get workspace root. skipping");
6966
return;
7067
};
71-
let data = RawWallTimeData::from_runtime_data(
72-
name,
73-
uri,
74-
iter_per_round,
75-
min_time_ns,
76-
max_time_ns,
77-
times_ns,
78-
);
68+
let data = RawWallTimeData::from_runtime_data(name, uri, iter_per_round, max_time_ns, times_ns);
7969
data.dump_to_results(&workspace_root, scope);
8070
}

crates/divan_compat/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ categories = [
1818
keywords = ["codspeed", "benchmark", "divan"]
1919

2020
[dependencies]
21-
codspeed = { path = "../codspeed", version = "=2.7.2" }
22-
divan = "0.1.17"
21+
codspeed = { path = "../codspeed", version = "2.7.2" }
22+
divan = { git = "https://github.com/CodSpeedHQ/divan" }
2323
codspeed-divan-compat-macros = { version = "=2.7.2", path = './macros' }
2424

2525
[[bench]]

0 commit comments

Comments
 (0)