Skip to content

chore: remove deprecated feature from cargo-codspeed release build #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2025
Merged

chore: remove deprecated feature from cargo-codspeed release build #76

merged 3 commits into from
Feb 14, 2025
+5 −5

Conversation

@GuillaumeLagrange
Copy link
Contributor

No description provided.

@GuillaumeLagrange GuillaumeLagrange force-pushed the remove-vendored-ssl-from-release-script branch from dd0ddcb to 2b355d1 Compare February 13, 2025 14:58
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #76 will degrade performances by 3.26%

Comparing remove-vendored-ssl-from-release-script (cb639f1) with main (98be94e)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ mut_borrow 866.7 ns 895.8 ns -3.26%
⚡ recursive_memoized[BTreeMap<u64, u64>, 0] 400.8 ns 371.7 ns +7.85%

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2025 •
edited
Loading

CodSpeed Walltime Performance Report

Merging #76 will degrade performances by 51.69%

Comparing remove-vendored-ssl-from-release-script (cb639f1) with main (98be94e)

Summary

⚡ 7 improvements
❌ 4 regressions
✅ 87 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ recursive[10] 6.9 µs 6.6 µs +5.31%
❌ recursive_memoized[BTreeMap<u64, u64>, 10] 4 µs 4.1 µs -3.47%
❌ recursive_memoized[BTreeMap<u64, u64>, 20] 1.7 µs 3.4 µs -48.76%
⚡ generate_combinations[8] 3.3 µs 3.1 µs +7.4%
⚡ graph_coloring[3] 1.1 µs 1 µs +4.71%
⚡ graph_coloring[5] 4 µs 2.4 µs +66.64%
⚡ permutations[5] 14.9 µs 14.1 µs +5.43%
⚡ permutations[7] 799.6 µs 766.9 µs +4.27%
⚡ find_highest_set_bit[1024] 5.8 µs 2.9 µs ×2
❌ generate_gray_code[1] 2.1 µs 4.1 µs -50%
❌ system_time 3.3 µs 6.8 µs -51.69%

@GuillaumeLagrange GuillaumeLagrange force-pushed the remove-vendored-ssl-from-release-script branch from ab931e0 to b11e0a1 Compare February 13, 2025 15:37
@GuillaumeLagrange GuillaumeLagrange force-pushed the remove-vendored-ssl-from-release-script branch from b11e0a1 to d7fb152 Compare February 14, 2025 08:48
@GuillaumeLagrange GuillaumeLagrange merged commit cb639f1 into main Feb 14, 2025
5 of 6 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the remove-vendored-ssl-from-release-script branch February 14, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@art049 art049 art049 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeLagrange @art049