Merge branch 'main' into cod-1742-codspeed-go-flamegraph-not-shown-for-many-benchmarks

Author: not-matthias

CHANGELOG.md

@@ -5,6 +5,36 @@
 
 
 
+## [4.4.1] - 2025-11-21
+
+### <!-- 0 -->🚀 Features
+- Display oidc as announcement by @fargito
+- Add --allow-empty run option by @GuillaumeLagrange in [#160](https://github.com/CodSpeedHQ/runner/pull/160)
+
+### <!-- 1 -->🐛 Bug Fixes
+- Do not espace trailing newlines in logger by @fargito
+- Make multiline logs appear correctly in summary by @fargito in [#162](https://github.com/CodSpeedHQ/runner/pull/162)
+- Request OIDC token just before upload by @fargito
+- Update docs links to oidc by @fargito in [#159](https://github.com/CodSpeedHQ/runner/pull/159)
+
+
+## [4.4.0] - 2025-11-19
+
+### <!-- 0 -->🚀 Features
+- Add support for oidc token authentication by @fargito in [#156](https://github.com/CodSpeedHQ/runner/pull/156)
+- Accept simulation as runner mode by @GuillaumeLagrange in [#152](https://github.com/CodSpeedHQ/runner/pull/152)
+- Add a comment explaining why we do not check for emptiness in valgrind teardown by @GuillaumeLagrange in [#157](https://github.com/CodSpeedHQ/runner/pull/157)
+- Validate walltime results before uploading by @GuillaumeLagrange
+- Import walltime_results from monorepo by @GuillaumeLagrange
+
+### <!-- 1 -->🐛 Bug Fixes
+- Dont start perf unless it's not already started by @not-matthias in [#158](https://github.com/CodSpeedHQ/runner/pull/158)
+- Use a line buffer when reading stdout/stderr streams by @GuillaumeLagrange
+
+### <!-- 7 -->⚙️ Internals
+- Update AGENTS.md to use cargo nextest if available by @GuillaumeLagrange
+
+
 ## [4.3.4] - 2025-11-10
 
 ### <!-- 0 -->🚀 Features
@@ -580,6 +610,8 @@
 - Add linting components to the toolchain by @art049
 
 
+[4.4.1]: https://github.com/CodSpeedHQ/runner/compare/v4.4.0..v4.4.1
+[4.4.0]: https://github.com/CodSpeedHQ/runner/compare/v4.3.4..v4.4.0
 [4.3.4]: https://github.com/CodSpeedHQ/runner/compare/v4.3.3..v4.3.4
 [4.3.3]: https://github.com/CodSpeedHQ/runner/compare/v4.3.2..v4.3.3
 [4.3.2]: https://github.com/CodSpeedHQ/runner/compare/v4.3.1..v4.3.2

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "codspeed-runner"
-version = "4.3.4"
+version = "4.4.1"
 edition = "2024"
 repository = "https://github.com/CodSpeedHQ/runner"
 publish = false

Cargo.toml

@@ -60,7 +60,7 @@ pub struct Cli {
 #[derive(Subcommand, Debug)]
 enum Commands {
     /// Run the bench command and upload the results to CodSpeed
-    Run(run::RunArgs),
+    Run(Box<run::RunArgs>),
     /// Manage the CLI authentication state
     Auth(auth::AuthArgs),
     /// Pre-install the codspeed executors
@@ -88,7 +88,7 @@ pub async fn run() -> Result<()> {
 
     match cli.command {
         Commands::Run(args) => {
-            run::run(args, &api_client, &codspeed_config, setup_cache_dir).await?
+            run::run(*args, &api_client, &codspeed_config, setup_cache_dir).await?
         }
         Commands::Auth(args) => auth::run(args, &api_client, cli.config_name.as_deref()).await?,
         Commands::Setup => setup::setup(setup_cache_dir).await?,

src/app.rs

@@ -1,6 +1,7 @@
 /// This target is used exclusively to handle group events.
 pub const GROUP_TARGET: &str = "codspeed::group";
 pub const OPENED_GROUP_TARGET: &str = "codspeed::group::opened";
+pub const ANNOUNCEMENT_TARGET: &str = "codspeed::announcement";
 
 #[macro_export]
 /// Start a new log group. All logs between this and the next `end_group!` will be grouped together.
@@ -43,6 +44,15 @@ macro_rules! end_group {
     };
 }
 
+#[macro_export]
+/// Logs at the announcement level. This is intended for important announcements like new features,
+/// that do not require immediate user action.
+macro_rules! announcement {
+    ($name:expr) => {
+        log::log!(target: $crate::logger::ANNOUNCEMENT_TARGET, log::Level::Info, "{}", $name);
+    };
+}
+
 pub enum GroupEvent {
     Start(String),
     StartOpened(String),
@@ -72,6 +82,14 @@ pub(super) fn get_group_event(record: &log::Record) -> Option<GroupEvent> {
     }
 }
 
+pub(super) fn get_announcement_event(record: &log::Record) -> Option<String> {
+    if record.target() != ANNOUNCEMENT_TARGET {
+        return None;
+    }
+
+    Some(record.args().to_string())
+}
+
 #[macro_export]
 /// Log a structured JSON output
 macro_rules! log_json {

src/logger.rs

@@ -1,4 +1,4 @@
-pub use crate::{end_group, log_json, start_group, start_opened_group};
+pub use crate::{announcement, end_group, log_json, start_group, start_opened_group};
 #[allow(unused_imports)]
 pub use anyhow::{Context, Error, Result, anyhow, bail, ensure};
 pub use itertools::Itertools;

src/prelude.rs

@@ -4,11 +4,13 @@ use reqwest_middleware::{ClientBuilder as ClientWithMiddlewareBuilder, ClientWit
 use reqwest_retry::{RetryTransientMiddleware, policies::ExponentialBackoff};
 
 const UPLOAD_RETRY_COUNT: u32 = 3;
+const OIDC_RETRY_COUNT: u32 = 10;
+const USER_AGENT: &str = "codspeed-runner";
 
 lazy_static! {
     pub static ref REQUEST_CLIENT: ClientWithMiddleware = ClientWithMiddlewareBuilder::new(
         ClientBuilder::new()
-            .user_agent("codspeed-runner")
+            .user_agent(USER_AGENT)
             .build()
             .unwrap()
     )
@@ -19,7 +21,19 @@ lazy_static! {
 
     // Client without retry middleware for streaming uploads (can't be cloned)
     pub static ref STREAMING_CLIENT: reqwest::Client = ClientBuilder::new()
-        .user_agent("codspeed-runner")
+        .user_agent(USER_AGENT)
         .build()
         .unwrap();
+
+    // Client with retry middleware for OIDC token requests
+    pub static ref OIDC_CLIENT: ClientWithMiddleware = ClientWithMiddlewareBuilder::new(
+        ClientBuilder::new()
+            .user_agent(USER_AGENT)
+            .build()
+            .unwrap()
+    )
+    .with(RetryTransientMiddleware::new_with_policy(
+        ExponentialBackoff::builder().build_with_max_retries(OIDC_RETRY_COUNT)
+    ))
+    .build();
 }

src/request_client.rs

@@ -25,6 +25,7 @@ pub struct Config {
     pub skip_upload: bool,
     pub skip_run: bool,
     pub skip_setup: bool,
+    pub allow_empty: bool,
 }
 
 #[derive(Debug, PartialEq, Clone)]
@@ -58,6 +59,7 @@ impl Config {
             skip_upload: false,
             skip_run: false,
             skip_setup: false,
+            allow_empty: false,
         }
     }
 }
@@ -97,6 +99,7 @@ impl TryFrom<RunArgs> for Config {
             skip_upload: args.skip_upload,
             skip_run: args.skip_run,
             skip_setup: args.skip_setup,
+            allow_empty: args.allow_empty,
         })
     }
 }
@@ -131,6 +134,7 @@ mod tests {
             skip_upload: false,
             skip_run: false,
             skip_setup: false,
+            allow_empty: false,
             perf_run_args: PerfRunArgs {
                 enable_perf: false,
                 perf_unwinding_mode: None,
@@ -146,6 +150,7 @@ mod tests {
         assert!(!config.skip_upload);
         assert!(!config.skip_run);
         assert!(!config.skip_setup);
+        assert!(!config.allow_empty);
         assert_eq!(config.command, "cargo codspeed bench");
     }
 
@@ -165,6 +170,7 @@ mod tests {
             skip_upload: true,
             skip_run: true,
             skip_setup: true,
+            allow_empty: true,
             perf_run_args: PerfRunArgs {
                 enable_perf: false,
                 perf_unwinding_mode: Some(UnwindingMode::FramePointer),
@@ -199,6 +205,7 @@ mod tests {
         assert!(config.skip_upload);
         assert!(config.skip_run);
         assert!(config.skip_setup);
+        assert!(config.allow_empty);
         assert_eq!(config.command, "cargo codspeed bench");
     }
 

src/run/config.rs

@@ -68,6 +68,9 @@ pub struct RunArgs {
     pub upload_url: Option<String>,
 
     /// The token to use for uploading the results,
+    ///
+    /// It can be either a CodSpeed token retrieved from the repository setting
+    /// or an OIDC token issued by the identity provider.
     #[arg(long, env = "CODSPEED_TOKEN")]
     pub token: Option<String>,
 
@@ -127,6 +130,10 @@ pub struct RunArgs {
     #[arg(long, default_value = "false", hide = true)]
     pub skip_setup: bool,
 
+    /// Allow runs without any benchmarks to succeed instead of failing
+    #[arg(long, default_value = "false", hide = true)]
+    pub allow_empty: bool,
+
     #[command(flatten)]
     pub perf_run_args: PerfRunArgs,
 
@@ -166,6 +173,7 @@ impl RunArgs {
             skip_upload: false,
             skip_run: false,
             skip_setup: false,
+            allow_empty: false,
             perf_run_args: PerfRunArgs {
                 enable_perf: false,
                 perf_unwinding_mode: None,
@@ -183,7 +191,7 @@ pub async fn run(
 ) -> Result<()> {
     let output_json = args.message_format == Some(MessageFormat::Json);
     let mut config = Config::try_from(args)?;
-    let provider = run_environment::get_provider(&config)?;
+    let mut provider = run_environment::get_provider(&config)?;
     let logger = Logger::new(&provider)?;
 
     #[allow(deprecated)]
@@ -205,6 +213,8 @@ pub async fn run(
         }
         debug!("Using the token from the CodSpeed configuration file");
         config.set_token(codspeed_config.auth.token.clone());
+    } else {
+        provider.check_oidc_configuration(&config)?;
     }
 
     let system_info = SystemInfo::new()?;
@@ -255,6 +265,12 @@ pub async fn run(
     };
 
     if !config.skip_upload {
+        if provider.get_run_environment() != RunEnvironment::Local {
+            // If relevant, set the OIDC token for authentication
+            // Note: OIDC tokens can expire quickly, so we set it just before the upload
+            provider.set_oidc_token(&mut config).await?;
+        }
+
         start_group!("Uploading performance data");
         let upload_result =
             uploader::upload(&config, &system_info, &provider, &run_data, executor.name()).await?;

src/run/mod.rs

@@ -1,5 +1,5 @@
 use crate::{
-    logger::{GroupEvent, get_group_event, get_json_event},
+    logger::{GroupEvent, get_announcement_event, get_group_event, get_json_event},
     run::run_environment::logger::should_provider_logger_handle_record,
 };
 use log::*;
@@ -53,6 +53,11 @@ impl Log for BuildkiteLogger {
             return;
         }
 
+        if let Some(announcement) = get_announcement_event(record) {
+            println!("[ANNOUNCEMENT] {announcement}");
+            return;
+        }
+
         if level > self.log_level {
             return;
         }