We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent a5a74e9 commit 8a5fdcbCopy full SHA for 8a5fdcb
src/run/runner/valgrind/executor.rs
@@ -50,6 +50,13 @@ impl Executor for ValgrindExecutor {
50
) -> Result<()> {
51
harvest_perf_maps(&run_data.profile_folder).await?;
52
53
+ // No matter the command in input, at this point valgrind will have been run and have produced output files.
54
+ //
55
+ // Contrary to walltime, checking that benchmarks have been detected here would require
56
+ // parsing the valgrind output files, which is not ideal at this stage.
57
+ // A comprehensive message will be sent to the user if no benchmarks are detected,
58
+ // even if it's later in the process than technically possible.
59
+
60
Ok(())
61
}
62
0 commit comments