Skip to content

Commit 8a5fdcb

Browse files
feat: add a comment explaining why we do not check for emptiness in valgrind teardown
1 parent a5a74e9 commit 8a5fdcb

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/run/runner/valgrind/executor.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ impl Executor for ValgrindExecutor {
5050
) -> Result<()> {
5151
harvest_perf_maps(&run_data.profile_folder).await?;
5252

53+
// No matter the command in input, at this point valgrind will have been run and have produced output files.
54+
//
55+
// Contrary to walltime, checking that benchmarks have been detected here would require
56+
// parsing the valgrind output files, which is not ideal at this stage.
57+
// A comprehensive message will be sent to the user if no benchmarks are detected,
58+
// even if it's later in the process than technically possible.
59+
5360
Ok(())
5461
}
5562
}

0 commit comments

Comments
 (0)