fix: cargo clippy lints

Author: not-matthias

src/api_client.rs

@@ -170,7 +170,7 @@ impl CodSpeedAPIClient {
             .await;
         match response {
             Ok(response) => Ok(response.create_login_session),
-            Err(err) => bail!("Failed to create login session: {}", err),
+            Err(err) => bail!("Failed to create login session: {err}"),
         }
     }
 
@@ -189,7 +189,7 @@ impl CodSpeedAPIClient {
             .await;
         match response {
             Ok(response) => Ok(response.consume_login_session),
-            Err(err) => bail!("Failed to use login session: {}", err),
+            Err(err) => bail!("Failed to use login session: {err}"),
         }
     }
 
@@ -212,7 +212,7 @@ impl CodSpeedAPIClient {
             Err(err) if err.contains_error_code("UNAUTHENTICATED") => {
                 bail!("Your session has expired, please login again using `codspeed auth login`")
             }
-            Err(err) => bail!("Failed to fetch local run report: {}", err),
+            Err(err) => bail!("Failed to fetch local run report: {err}"),
         }
     }
 }

src/config.rs

@@ -56,7 +56,7 @@ impl CodSpeedConfig {
                 debug!("Config file not found at {}", config_path.display());
                 CodSpeedConfig::default()
             }
-            Err(e) => bail!("Failed to load config: {}", e),
+            Err(e) => bail!("Failed to load config: {e}"),
         };
 
         if let Some(oauth_token) = oauth_token_override {

src/run/config.rs

@@ -70,7 +70,7 @@ impl TryFrom<RunArgs> for Config {
         let instruments = Instruments::try_from(&args)?;
         let raw_upload_url = args.upload_url.unwrap_or_else(|| DEFAULT_UPLOAD_URL.into());
         let upload_url = Url::parse(&raw_upload_url)
-            .map_err(|e| anyhow!("Invalid upload URL: {}, {}", raw_upload_url, e))?;
+            .map_err(|e| anyhow!("Invalid upload URL: {raw_upload_url}, {e}"))?;
 
         Ok(Self {
             upload_url,

src/run/helpers/download_file.rs

@@ -9,7 +9,7 @@ pub async fn download_file(url: &Url, path: &Path) -> Result<()> {
         .get(url.clone())
         .send()
         .await
-        .map_err(|e| anyhow!("Failed to download file: {}", e))?;
+        .map_err(|e| anyhow!("Failed to download file: {e}"))?;
     if !response.status().is_success() {
         bail!("Failed to download file: {}", response.status());
     }
@@ -18,13 +18,8 @@ pub async fn download_file(url: &Url, path: &Path) -> Result<()> {
     let content = response
         .bytes()
         .await
-        .map_err(|e| anyhow!("Failed to read response: {}", e))?;
-    std::io::copy(&mut content.as_ref(), &mut file).map_err(|e| {
-        anyhow!(
-            "Failed to write to file: {}, {}",
-            path.display(),
-            e.to_string()
-        )
-    })?;
+        .map_err(|e| anyhow!("Failed to read response: {e}"))?;
+    std::io::copy(&mut content.as_ref(), &mut file)
+        .map_err(|e| anyhow!("Failed to write to file: {}, {}", path.display(), e))?;
     Ok(())
 }

src/run/helpers/get_env_var.rs

@@ -3,7 +3,7 @@ use anyhow::anyhow;
 use std::env;
 
 pub fn get_env_variable(name: &str) -> Result<String> {
-    env::var(name).map_err(|_| anyhow!("{} environment variable not found", name))
+    env::var(name).map_err(|_| anyhow!("{name} environment variable not found"))
 }
 
 #[cfg(test)]

src/run/helpers/parse_git_remote.rs

@@ -17,10 +17,7 @@ pub struct GitRemote {
 
 pub fn parse_git_remote(remote: &str) -> Result<GitRemote> {
     let captures = REMOTE_REGEX.captures(remote).ok_or_else(|| {
-        anyhow!(
-            "Could not extract owner and repository from remote url: {}",
-            remote
-        )
+        anyhow!("Could not extract owner and repository from remote url: {remote}")
     })?;
 
     let domain = captures.name("domain").unwrap().as_str();

src/run/instruments/mod.rs

@@ -47,7 +47,7 @@ impl TryFrom<&RunArgs> for Instruments {
         for instrument_name in &args.instruments {
             match instrument_name.as_str() {
                 "mongodb" => validated_instrument_names.insert(InstrumentName::MongoDB),
-                _ => bail!("Invalid instrument name: {}", instrument_name),
+                _ => bail!("Invalid instrument name: {instrument_name}"),
             };
         }
 

src/run/run_environment/gitlab_ci/provider.rs

@@ -101,7 +101,7 @@ impl TryFrom<&Config> for GitLabCIProvider {
                 None,
             ),
 
-            _ => bail!("Event {} is not supported by CodSpeed", ci_pipeline_source),
+            _ => bail!("Event {ci_pipeline_source} is not supported by CodSpeed"),
         };
 
         let run_id = get_env_variable("CI_JOB_ID")?;

src/run/run_environment/local/provider.rs

@@ -191,10 +191,7 @@ fn extract_provider_owner_and_repository_from_remote_url(
     let repository_provider = match domain.as_str() {
         "github.com" => RepositoryProvider::GitHub,
         "gitlab.com" => RepositoryProvider::GitLab,
-        domain => bail!(
-            "Repository provider {} is not supported by CodSpeed",
-            domain
-        ),
+        domain => bail!("Repository provider {domain} is not supported by CodSpeed"),
     };
 
     Ok((

src/run/runner/valgrind/measure.rs

@@ -93,10 +93,10 @@ pub async fn measure(
         format!(
             "{}:{}:{}",
             introspected_nodejs::setup()
-                .map_err(|e| anyhow!("failed to setup NodeJS introspection. {}", e))?
+                .map_err(|e| anyhow!("failed to setup NodeJS introspection. {e}"))?
                 .to_string_lossy(),
             introspected_golang::setup()
-                .map_err(|e| anyhow!("failed to setup Go introspection. {}", e))?
+                .map_err(|e| anyhow!("failed to setup Go introspection. {e}"))?
                 .to_string_lossy(),
             env::var("PATH").unwrap_or_default(),
         ),
@@ -136,7 +136,7 @@ pub async fn measure(
     debug!("cmd: {cmd:?}");
     let status = run_command_with_log_pipe(cmd)
         .await
-        .map_err(|e| anyhow!("failed to execute the benchmark process. {}", e))?;
+        .map_err(|e| anyhow!("failed to execute the benchmark process. {e}"))?;
     debug!(
         "Valgrind exit code = {:?}, Valgrind signal = {:?}",
         status.code(),
@@ -157,14 +157,11 @@ pub async fn measure(
         let content = std::fs::read_to_string(&cmd_status_path)?;
         content
             .parse::<u32>()
-            .map_err(|e| anyhow!("unable to retrieve the program exit code. {}", e))?
+            .map_err(|e| anyhow!("unable to retrieve the program exit code. {e}"))?
     };
     debug!("Program exit code = {cmd_status}");
     if cmd_status != 0 {
-        bail!(
-            "failed to execute the benchmark process, exit code: {}",
-            cmd_status
-        );
+        bail!("failed to execute the benchmark process, exit code: {cmd_status}");
     }
 
     Ok(())