Skip to content

Commit 6ba9bfd

Browse files
carlosvaccaricarlosvaccari
committed
[ISSUE-43] - Ajustes de code review
1 parent 71b06a3 commit 6ba9bfd

File tree

6 files changed

+29
-28
lines changed

6 files changed

+29
-28
lines changed

‎core-shared-ui/src/main/java/com/codandotv/streamplayerapp/core_shared_ui/resources/Colors.kt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ object Colors {
99

1010
val LightColors = lightColorScheme(
1111
primary = Color(0xFFE50914),
12+
secondary = Color(0xFFF5F5F1),
1213
background = Color(0xFF000000),
1314
onBackground = Color(0xFFFFFFFF),
1415
surface = Color(0xFF121212),

‎feature-list-streams/src/main/java/com/codandotv/streamplayerapp/feature_list_streams/core/ContentType.kt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import androidx.annotation.StringRes
44
import com.codandotv.streamplayerapp.feature_list_streams.R
55

66
enum class ContentType(@StringRes val contentName: Int, @StringRes val contentNameAsPlural: Int) {
7-
SHOW(R.string.content_type_show, R.string.content_type_show_plural),
8-
FILM(R.string.content_type_film, R.string.content_type_film_plural);
7+
SHOW(R.string.list_content_type_show, R.string.list_content_type_show_plural),
8+
FILM(R.string.list_content_type_film, R.string.list_content_type_film_plural);
99

1010
companion object {
1111
fun getContentName(contentType: ContentType) =

‎feature-list-streams/src/main/java/com/codandotv/streamplayerapp/feature_list_streams/list/presentation/ListStreamUimodel.kt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ class ListStreamUiModelImpl(
4747
contentTypeAsPlural = ContentType.getContentNameAsPlural(ContentType.FILM),
4848
extraInfo = IconAndTextInfo(
4949
R.drawable.ic_top_10,
50-
R.string.highlight_banner_stream_ranking
50+
R.string.list_highlight_banner_stream_ranking
5151
),
52-
leftButton = IconAndTextInfo(drawable.ic_add, R.string.highlight_banner_add),
53-
centralButton = IconAndTextInfo(drawable.ic_play, R.string.highlight_banner_watch),
54-
rightButton = IconAndTextInfo(drawable.ic_info, R.string.highlight_banner_info),
52+
leftButton = IconAndTextInfo(drawable.ic_add, R.string.list_highlight_banner_add),
53+
centralButton = IconAndTextInfo(drawable.ic_play, R.string.list_highlight_banner_watch),
54+
rightButton = IconAndTextInfo(drawable.ic_info, R.string.list_highlight_banner_info),
5555
)
5656
}
5757
}

‎feature-list-streams/src/main/java/com/codandotv/streamplayerapp/feature_list_streams/list/presentation/widgets/HighlightBanner.kt‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ fun ContentImage(modifier: Modifier = Modifier, imageUrl: String) {
7474
modifier = modifier.fillMaxSize(),
7575
model = imageUrl,
7676
contentScale = ContentScale.Crop,
77-
contentDescription = stringResource(id = R.string.highligh_banner_content)
77+
contentDescription = stringResource(id = R.string.list_highligh_banner_content)
7878
)
7979
}
8080

@@ -116,7 +116,7 @@ fun ContentRanking(
116116
Row(modifier = modifier, verticalAlignment = Alignment.CenterVertically) {
117117
Icon(
118118
painter = painterResource(id = extraInfo.icon),
119-
contentDescription = stringResource(id = R.string.icon_highligh_banner_ranking),
119+
contentDescription = stringResource(id = R.string.list_icon_highligh_banner_ranking),
120120
modifier = Modifier.size(24.dp),
121121
tint = Color.Unspecified
122122
)
@@ -186,7 +186,7 @@ fun AddToListButton(
186186
Column(horizontalAlignment = Alignment.CenterHorizontally) {
187187
Icon(
188188
painter = painterResource(id = drawable.ic_add),
189-
contentDescription = stringResource(id = R.string.icon_add),
189+
contentDescription = stringResource(id = R.string.list_icon_add),
190190
tint = Color.White,
191191
)
192192
Text(
@@ -208,7 +208,7 @@ fun InfoButton(
208208
Column(horizontalAlignment = Alignment.CenterHorizontally) {
209209
Icon(
210210
painter = painterResource(id = drawable.ic_info),
211-
contentDescription = stringResource(id = R.string.icon_info),
211+
contentDescription = stringResource(id = R.string.list_icon_info),
212212
tint = Color.White
213213
)
214214
Text(
@@ -239,13 +239,13 @@ fun PlayButton(
239239
) {
240240
Icon(
241241
painter = painterResource(drawable.ic_play),
242-
contentDescription = stringResource(id = R.string.icon_play),
242+
contentDescription = stringResource(id = R.string.list_icon_play),
243243
tint = Color.Black,
244244
modifier = Modifier.padding(vertical = 8.dp)
245245
)
246246
Spacer(modifier = Modifier.width(4.dp))
247247
Text(
248-
text = stringResource(id = R.string.highlight_banner_watch),
248+
text = stringResource(id = R.string.list_highlight_banner_watch),
249249
color = Color.Black,
250250
fontSize = 14.sp,
251251
modifier = Modifier
@@ -268,9 +268,9 @@ fun HighlightBannerPreview() {
268268
R.drawable.ic_top_10,
269269
ContentType.getContentName(ContentType.SHOW)
270270
),
271-
leftButton = IconAndTextInfo(drawable.ic_add, R.string.highlight_banner_add),
272-
centralButton = IconAndTextInfo(drawable.ic_play, R.string.highlight_banner_watch),
273-
rightButton = IconAndTextInfo(drawable.ic_info, R.string.highlight_banner_info),
271+
leftButton = IconAndTextInfo(drawable.ic_add, R.string.list_highlight_banner_add),
272+
centralButton = IconAndTextInfo(drawable.ic_play, R.string.list_highlight_banner_watch),
273+
rightButton = IconAndTextInfo(drawable.ic_info, R.string.list_highlight_banner_info),
274274
)
275275
)
276276
}

‎feature-list-streams/src/main/res/values/content-description.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources>
3-
<string name="icon_play">Ícone Reprodução</string>
4-
<string name="icon_add">Ícone adicionar</string>
5-
<string name="icon_info">Ícone informações</string>
6-
<string name="highligh_banner_content">Poster de conteúdo em destaque</string>
7-
<string name="icon_highligh_banner_ranking">Ícone top 10</string>
3+
<string name="list_icon_play">Ícone Reprodução</string>
4+
<string name="list_icon_add">Ícone adicionar</string>
5+
<string name="list_icon_info">Ícone informações</string>
6+
<string name="list_highligh_banner_content">Poster de conteúdo em destaque</string>
7+
<string name="list_icon_highligh_banner_ranking">Ícone top 10</string>
88
</resources>

‎feature-list-streams/src/main/res/values/strings.xml‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
<string name="detail_back">Voltar</string>
1212

1313
<!-- region Highlight banner -->
14-
<string name="content_type_show">Série</string>
15-
<string name="content_type_show_plural">Séries</string>
16-
<string name="content_type_film">Filme</string>
17-
<string name="content_type_film_plural">Filmes</string>
14+
<string name="list_content_type_show">Série</string>
15+
<string name="list_content_type_show_plural">Séries</string>
16+
<string name="list_content_type_film">Filme</string>
17+
<string name="list_content_type_film_plural">Filmes</string>
1818

19-
<string name="highlight_banner_add">Minha lista</string>
20-
<string name="highlight_banner_info">Saiba mais</string>
21-
<string name="highlight_banner_watch">Assistir</string>
22-
<string name="highlight_banner_stream_ranking">Top 1 em %s hoje</string>
19+
<string name="list_highlight_banner_add">Minha lista</string>
20+
<string name="list_highlight_banner_info">Saiba mais</string>
21+
<string name="list_highlight_banner_watch">Assistir</string>
22+
<string name="list_highlight_banner_stream_ranking">Top 1 em %s hoje</string>
2323
<!-- endregion Highlight banner -->
2424

2525
</resources>

0 commit comments

Comments
 (0)