added more tests for lfu

Author: Code-Hex

lfu/lfu.go

@@ -58,14 +58,14 @@ func (c *Cache[K, V]) Set(key K, val V, opts ...cache.ItemOption) {
 		return
 	}
 
-	e := newEntry(key, val, opts...)
-	heap.Push(c.queue, e)
-	c.items[key] = e
-
-	if len(c.items) > c.cap {
+	if len(c.items) == c.cap {
 		evictedEntry := heap.Pop(c.queue).(*entry[K, V])
 		delete(c.items, evictedEntry.item.Key)
 	}
+
+	e := newEntry(key, val, opts...)
+	heap.Push(c.queue, e)
+	c.items[key] = e
 }
 
 // Keys returns the keys of the cache. the order is from oldest to newest.
@@ -99,3 +99,10 @@ func (c *Cache[K, V]) Contains(key K) bool {
 	}
 	return !e.item.HasExpired()
 }
+
+// Len returns the number of items in the cache.
+func (c *Cache[K, V]) Len() int {
+	c.mu.RLock()
+	defer c.mu.RUnlock()
+	return c.queue.Len()
+}

lfu/lfu_internal_test.go

@@ -0,0 +1,69 @@
+package lfu
+
+import (
+	"testing"
+	"time"
+
+	cache "github.com/Code-Hex/go-generics-cache"
+)
+
+func TestContains(t *testing.T) {
+	t.Run("without expiration", func(t *testing.T) {
+		cache := NewCache[string, int]()
+		cache.Set("foo", 1)
+		cache.Set("bar", 2)
+		cache.Set("baz", 3)
+		for _, key := range []string{
+			"foo",
+			"bar",
+			"baz",
+		} {
+			if !cache.Contains(key) {
+				t.Errorf("not found: %s", key)
+			}
+		}
+		if cache.Contains("not found") {
+			t.Errorf("found")
+		}
+	})
+
+	t.Run("with expiration", func(t *testing.T) {
+		c := NewCache[string, int]()
+		key := "foo"
+		exp := time.Hour
+		c.Set(key, 1, cache.WithExpiration(exp))
+		// modify directly
+		e, ok := c.items[key]
+		if !ok {
+			t.Fatal("unexpected not found key")
+		}
+		item := e.item
+		item.CreatedAt = time.Now().Add(-2 * exp)
+
+		if c.Contains(key) {
+			t.Errorf("found")
+		}
+	})
+}
+
+func TestGet(t *testing.T) {
+	c := NewCache[string, int]()
+	key := "foo"
+	exp := time.Hour
+	c.Set(key, 1, cache.WithExpiration(exp))
+	_, ok := c.Get(key)
+	if !ok {
+		t.Fatal("unexpected not found")
+	}
+	// modify directly
+	e, ok := c.items[key]
+	if !ok {
+		t.Fatal("unexpected not found key")
+	}
+	item := e.item
+	item.CreatedAt = time.Now().Add(-2 * exp)
+	_, ok2 := c.Get(key)
+	if ok2 {
+		t.Fatal("unexpected found (expired)")
+	}
+}

lfu/lfu_test.go

@@ -0,0 +1,65 @@
+package lfu_test
+
+import (
+	"testing"
+
+	"github.com/Code-Hex/go-generics-cache/lfu"
+)
+
+func TestSet(t *testing.T) {
+	// set capacity is 1
+	cache := lfu.NewCacheWithCap[string, int](1)
+	cache.Set("foo", 1)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+	if got, ok := cache.Get("foo"); got != 1 || !ok {
+		t.Fatalf("invalid value got %d, cachehit %v", got, ok)
+	}
+
+	// if over the cap
+	cache.Set("bar", 2)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+	bar, ok := cache.Get("bar")
+	if bar != 2 || !ok {
+		t.Fatalf("invalid value bar %d, cachehit %v", bar, ok)
+	}
+
+	// checks deleted oldest
+	if _, ok := cache.Get("foo"); ok {
+		t.Fatalf("invalid delete oldest value foo %v", ok)
+	}
+
+	// valid: if over the cap but same key
+	cache.Set("bar", 100)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+	bar, ok = cache.Get("bar")
+	if bar != 100 || !ok {
+		t.Fatalf("invalid replacing value bar %d, cachehit %v", bar, ok)
+	}
+}
+
+func TestDelete(t *testing.T) {
+	cache := lfu.NewCacheWithCap[string, int](1)
+	cache.Set("foo", 1)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+
+	cache.Delete("foo2")
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length after deleted does not exist key: %d", got)
+	}
+
+	cache.Delete("foo")
+	if got := cache.Len(); got != 0 {
+		t.Fatalf("invalid length after deleted: %d", got)
+	}
+	if _, ok := cache.Get("foo"); ok {
+		t.Fatalf("invalid get after deleted %v", ok)
+	}
+}