added more test and fixed some logix for lru cache

Author: Code-Hex

lru/lru.go

@@ -48,10 +48,11 @@ func (c *Cache[K, V]) Get(key K) (zero V, _ bool) {
 func (c *Cache[K, V]) Set(key K, val V) {
 	c.mu.Lock()
 	defer c.mu.Unlock()
+
 	if e, ok := c.items[key]; ok {
 		// updates cache order
 		c.list.MoveToFront(e)
-		e.Value = val
+		e.Value.(*item[K, V]).Value = val
 		return
 	}
 
@@ -70,7 +71,6 @@ func (c *Cache[K, V]) Set(key K, val V) {
 func (c *Cache[K, V]) Keys() []K {
 	c.mu.RLock()
 	defer c.mu.RUnlock()
-
 	keys := make([]K, 0, len(c.items))
 	for ent := c.list.Back(); ent != nil; ent = ent.Prev() {
 		keys = append(keys, ent.Value.(*item[K, V]).Key)
@@ -81,7 +81,7 @@ func (c *Cache[K, V]) Keys() []K {
 // Len returns the number of items in the cache.
 func (c *Cache[K, V]) Len() int {
 	c.mu.RLock()
-	defer c.mu.RLock()
+	defer c.mu.RUnlock()
 	return c.list.Len()
 }
 

lru/lru_test.go

@@ -0,0 +1,82 @@
+package lru_test
+
+import (
+	"testing"
+
+	"github.com/Code-Hex/go-generics-cache/lru"
+)
+
+func TestSet(t *testing.T) {
+	// set capacity is 1
+	cache := lru.NewCap[string, int](1)
+	cache.Set("foo", 1)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+	if got, ok := cache.Get("foo"); got != 1 || !ok {
+		t.Fatalf("invalid value got %d, cachehit %v", got, ok)
+	}
+
+	// if over the cap
+	cache.Set("bar", 2)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+	bar, ok := cache.Get("bar")
+	if bar != 2 || !ok {
+		t.Fatalf("invalid value bar %d, cachehit %v", bar, ok)
+	}
+
+	// checks deleted oldest
+	if _, ok := cache.Get("foo"); ok {
+		t.Fatalf("invalid delete oldest value foo %v", ok)
+	}
+
+	// valid: if over the cap but same key
+	cache.Set("bar", 100)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+	bar, ok = cache.Get("bar")
+	if bar != 100 || !ok {
+		t.Fatalf("invalid replacing value bar %d, cachehit %v", bar, ok)
+	}
+}
+
+func TestContains(t *testing.T) {
+	cache := lru.New[string, int]()
+	cache.Set("foo", 1)
+	cache.Set("bar", 2)
+	cache.Set("baz", 3)
+	for _, key := range []string{
+		"foo",
+		"bar",
+		"baz",
+	} {
+		if !cache.Contains(key) {
+			t.Errorf("not found: %s", key)
+		}
+	}
+}
+
+func TestDelete(t *testing.T) {
+	cache := lru.NewCap[string, int](1)
+	cache.Set("foo", 1)
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length: %d", got)
+	}
+
+	cache.Delete("foo2")
+	if got := cache.Len(); got != 1 {
+		t.Fatalf("invalid length after deleted does not exist key: %d", got)
+	}
+
+	cache.Delete("foo")
+	if got := cache.Len(); got != 0 {
+		t.Fatalf("invalid length after deleted: %d", got)
+	}
+	if _, ok := cache.Get("foo"); ok {
+		t.Fatalf("invalid get after deleted %v", ok)
+	}
+
+}