Merge pull request #129 from Code52/associated-process-fix

the process may not exist, and that's okay

Author: shiftkey

src/Carnac.Logic/KeyProvider.cs

@@ -70,6 +70,7 @@ public IObservable<KeyPress> GetKeyStream()
                     .Select(DetectWindowsKey)
                     .Where(k => !IsModifierKeyPress(k) && k.KeyDirection == KeyDirection.Down)
                     .Select(ToCarnacKeyPress)
+                    .Where(keypress => keypress != null)
                     .Where(k => !passwordModeService.CheckPasswordMode(k.InterceptKeyEventArgs))
                     .Subscribe(observer);
 
@@ -98,6 +99,10 @@ bool IsModifierKeyPress(InterceptKeyEventArgs interceptKeyEventArgs)
         KeyPress ToCarnacKeyPress(InterceptKeyEventArgs interceptKeyEventArgs)
         {
             var process = GetAssociatedProcess();
+            if (process == null)
+            {
+                return null;
+            }
 
             var isLetter = interceptKeyEventArgs.IsLetter();
             var inputs = ToInputs(isLetter, winKeyPressed, interceptKeyEventArgs).ToArray();
@@ -107,7 +112,7 @@ KeyPress ToCarnacKeyPress(InterceptKeyEventArgs interceptKeyEventArgs)
                 ImageSource image = IconUtilities.GetProcessIconAsImageSource(processFileName);
                 return new KeyPress(new ProcessInfo(process.ProcessName, image), interceptKeyEventArgs, winKeyPressed, inputs);
             }
-            catch (System.Exception)
+            catch (Exception)
             {
                 return new KeyPress(new ProcessInfo(process.ProcessName), interceptKeyEventArgs, winKeyPressed, inputs); ;
             }
@@ -152,21 +157,25 @@ static IEnumerable<string> ToInputs(bool isLetter, bool isWinKeyPressed, Interce
 
         Process GetAssociatedProcess()
         {
-            Process process;
-
             var handle = GetForegroundWindow();
 
-            if (!processes.ContainsKey(handle))
+            if (processes.ContainsKey(handle))
+            {
+                return processes[handle];
+            }
+
+            uint processId;
+            GetWindowThreadProcessId(new IntPtr(handle), out processId);
+            try
             {
-                uint processId;
-                GetWindowThreadProcessId(new IntPtr(handle), out processId);
                 var p = Process.GetProcessById(Convert.ToInt32(processId));
                 processes.Add(handle, p);
-                process = p;
+                return p;
+            }
+            catch (ArgumentException ex)
+            {
+                return null;
             }
-            else
-                process = processes[handle];
-            return process;
         }
     }
 }